Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webtorrent/bittorrent-tracker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ebe3c21
Choose a base ref
...
head repository: webtorrent/bittorrent-tracker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3f3db7d
Choose a head ref
  • 20 commits
  • 9 files changed
  • 2 contributors

Commits on Feb 3, 2017

  1. ws client: Don't include offers with 'completed' event

    It's not necessary to include webrtc offers because the client is not
    really looking for more peers when it has just completed the torrent.
    
    Fewer WebRTC offers = less resource usage
    feross committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    30b6f17 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #197 from feross/fewer-offers

    ws client: Don't include offers with 'completed' event
    feross authored Feb 3, 2017
    Configuration menu
    Copy the full SHA
    9d5b55b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2017

  1. perf: disable perMessageDeflate

    From the ws docs:
    
    "ws supports the permessage-deflate extension extension which enables
    the client and server to negotiate a compression algorithm and its
    parameters, and then selectively apply it to the data payloads of each
    WebSocket message.
    
    The extension is enabled by default but adds a significant overhead in
    terms of performance and memory comsumption. We suggest to use
    WebSocket compression only if it is really needed.
    
    To disable the extension you can set the perMessageDeflate option to
    false"
    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    71bd413 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #200 from feross/disable-deflate

    perf: disable perMessageDeflate
    DiegoRBaquero authored Feb 8, 2017
    Configuration menu
    Copy the full SHA
    4c86e98 View commit details
    Browse the repository at this point in the history
  3. 8.3.0

    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    7616500 View commit details
    Browse the repository at this point in the history
  4. Fixes for PR #185

    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    27ae148 View commit details
    Browse the repository at this point in the history
  5. Fix bug where left = 0 would be converted to Infinity

    Possibly fixes: #196
    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    c2c8e36 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed3da2f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    62dd0f7 View commit details
    Browse the repository at this point in the history
  8. style: re-order methods

    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    6351f2b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8f33b95 View commit details
    Browse the repository at this point in the history
  10. Close websockets when peers are evicted from LRU cache

    Possibly fixes: #196
    
    Close websockets when peers are evicted from LRU cache, otherwise it's
    possible for a peer object to be evicted from the LRU cache without the
    socket being cleaned up. That will leak memory until the websocket is
    closed by the remote client. It also messes up the stats.
    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    7075088 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1b22b53 View commit details
    Browse the repository at this point in the history
  12. remove unneeded timeout

    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    29d4564 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d534582 View commit details
    Browse the repository at this point in the history
  14. test: ensure electron-webrtc is started only for test where it's needed

    before this change, it was getting initialized immediately, since it
    was outside a tape test block
    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    e731106 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4422067 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    cd4a976 View commit details
    Browse the repository at this point in the history
  17. Address @DiegoRBaquero's feedback

    From comment:
    #198 (comment)
    95
    feross committed Feb 8, 2017
    1 Configuration menu
    Copy the full SHA
    806ce1d View commit details
    Browse the repository at this point in the history
  18. client: socketPool should not be shared across clients

    Caught this issue because of the new eviction tests. Essentially, this
    change moves the socketPool into the client instance instead of a
    reused variable at the module level.
    
    When a client sends stop (or is evicted) the server will close the
    websocket connection if that client is not in any other swarms (based
    on peerId). However, if we are using a single socket for multiple
    clients (as was the case before this commit), then other clients will
    have their sockets unintentionally closed by the server.
    feross committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    3f3db7d View commit details
    Browse the repository at this point in the history
Loading