Fix issue where seeders improperly marked as leechers#185
Merged
feross merged 1 commit intowebtorrent:masterfrom Dec 5, 2016
sidd:master
Merged
Fix issue where seeders improperly marked as leechers#185feross merged 1 commit intowebtorrent:masterfrom sidd:master
feross merged 1 commit intowebtorrent:masterfrom
sidd:master
Conversation
Member
|
Looks good to me. I'm just going to swap |
feross
approved these changes
Dec 5, 2016
Member
|
8.0.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I was running into with traditional BitTorrent clients. The tracker was marking seeders as leechers, even though this was not the case.
When starting a new transfer with all of the files already downloaded, a
startedevent is sent out withleft=0(at least this is the case in Deluge and Transmission). Acompletedevent is explicitly not sent out (FTA https://wiki.theory.org/BitTorrentSpecification):Currently params.left is set to
Infinityeven if it was supplied asleft=0in the querystring. This fixes that issue, and retains the behavior of settingparams.leftto Infinity when it is unparseable.