docs(issues): add specs for HTTP announce request parameter fixes (#1985, #1986, #1987) - #1988
Merged
josecelano merged 5 commits intoJul 15, 2026
Conversation
…ring Add a new custom agent that clones external tracker repositories, searches their source code and issue trackers, and returns structured findings. Used before writing issue specs or during implementation when claims about other trackers need verification. The agent uses /tmp/tracker-research/ or the workspace .tmp/ directory for temporary artifacts.
There was a problem hiding this comment.
Pull request overview
This PR adds new issue specification documents under docs/issues/open/ for upcoming HTTP announce parameter behavior/compliance improvements, and introduces a new custom “Researcher” agent profile for external evidence gathering workflows.
Changes:
- Added three new open issue specs for #1985 (rename
peer_addr→ip), #1986 (compact peer list default), and #1987 (config option to honoripquery string). - Added two evidence documents capturing external-tracker behavior (opentracker and chihaya) around DNS-name handling for the
ipparameter. - Added a new
.github/agents/researcher.agent.mdcustom agent and updated spellcheck dictionary withhostnames.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| project-words.txt | Adds hostnames to the project dictionary. |
| docs/issues/open/1985-rename-peer-addr-to-ip-in-http-announce-request/ISSUE.md | New issue spec for BEP 3 ip rename + embedded ADR text. |
| docs/issues/open/1986-align-http-tracker-compact-default-with-bep-23/ISSUE.md | New issue spec to align default compact behavior with BEP 23. |
| docs/issues/open/1987-add-config-option-to-use-ip-from-announce-query-string/ISSUE.md | New issue spec for opt-in config to honor ip query param (security documented). |
| docs/issues/open/1987-add-config-option-to-use-ip-from-announce-query-string/evidence-opentracker-no-dns-support.md | Evidence write-up: opentracker does not support DNS names in ip. |
| docs/issues/open/1987-add-config-option-to-use-ip-from-announce-query-string/evidence-chihaya-no-dns-support.md | Evidence write-up: chihaya does not support DNS names in ip. |
| .github/agents/researcher.agent.md | Adds a “Researcher” custom agent definition for external evidence gathering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this pull request
Jul 15, 2026
- Fix broken relative link to docs/adrs/ in 1985 ISSUE.md (../adrs/ -> ../../adrs/ from the nested issue folder) - Fix broken relative links to sibling issues in 1985 ISSUE.md (../open/1978-... -> ../1978-...) - Fix broken relative links to sibling issues in 1987 ISSUE.md (../open/1978-... and ../open/1640-... -> ../1978-... and ../1640-...) - Clarify tool naming in researcher.agent.md: github_text_search / github_repo tools are optional; fall back to gh CLI when unavailable
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this pull request
Jul 15, 2026
- Fix broken relative link to docs/adrs/ in 1985 ISSUE.md (../adrs/ -> ../../adrs/ from the nested issue folder) - Fix broken relative links to sibling issues in 1985 ISSUE.md (../open/1978-... -> ../1978-...) - Fix broken relative links to sibling issues in 1987 ISSUE.md (../open/1978-... and ../open/1640-... -> ../1978-... and ../1640-...) - Clarify tool naming in researcher.agent.md: github_text_search / github_repo tools are optional; fall back to gh CLI when unavailable
josecelano
force-pushed
the
http-announce-request-param-specs
branch
from
July 15, 2026 18:25
35f39f9 to
20f9f77
Compare
…ref torrust#1985) Add issue spec for renaming the non-standard peer_addr GET parameter to the BEP 3-specified ip parameter. Includes an embedded ADR deciding to accept only IP addresses (not DNS names) in the ip parameter. Also add 'hostnames' to project-words.txt for the ADR text.
…orrust#1986) Add issue spec for returning compact peer list by default when the compact GET parameter is absent, aligning with the BEP 23 SUGGESTION. Includes manual verification steps using the tracker client.
…orrust#1987) Add issue spec for an opt-in per-HTTP-tracker configuration option to honour the ip GET parameter value as the peer address instead of the TCP connection IP. Sub-issue of torrust#1978 (configuration overhaul). Includes evidence from opentracker and chihaya confirming that neither tracker supports DNS names in the ip parameter.
- Fix broken relative link to docs/adrs/ in 1985 ISSUE.md (../adrs/ -> ../../adrs/ from the nested issue folder) - Fix broken relative links to sibling issues in 1985 ISSUE.md (../open/1978-... -> ../1978-...) - Fix broken relative links to sibling issues in 1987 ISSUE.md (../open/1978-... and ../open/1640-... -> ../1978-... and ../1640-...) - Clarify tool naming in researcher.agent.md: github_text_search / github_repo tools are optional; fall back to gh CLI when unavailable
josecelano
force-pushed
the
http-announce-request-param-specs
branch
from
July 15, 2026 18:27
20f9f77 to
ac9ba0e
Compare
Member
Author
|
ACK ac9ba0e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add three new issue specs for HTTP announce request parameter improvements:
#1985 — Rename
peer_addrGET param toip(BEP 3 compliance)peer_addrwire parameter to the BEP 3-specifiedipipparameter#1986 — Return compact peer list by default (BEP 23 compliance)
compactis absent#1987 — Add
use_ip_from_query_stringconfig option (sub-issue of #1978)ipGET param as the peer addresspeer_addrGET param toipin HTTP announce request (BEP 3) #1985New Researcher Agent
Also includes a new
.github/agents/researcher.agent.mdcustom agent for evidence-gathering tasks (external repo research, source code analysis, GitHub issue search).Commits
feat(agents): add Researcher custom agent for external evidence gatheringdocs(issue): add spec for renaming peer_addr to ip in HTTP announce (ref Renamepeer_addrGET param toipin HTTP announce request (BEP 3) #1985)docs(issue): add spec for compact peer list default per BEP 23 (ref Return compact peer list by default whencompactparam is absent (BEP 23) #1986)docs(issue): add spec for use_ip_from_query_string config option (ref Add per-HTTP-tracker config option to use peer IP fromipGET parameter (sub-issue of #1978) #1987)