Skip to content

Rename peer_addr GET param to ip in HTTP announce request (BEP 3) #1985

Description

@josecelano

Goal

Rename the HTTP announce GET parameter from the non-standard peer_addr to the BEP 3-specified ip, aligning the wire protocol with the specification. Rename the corresponding Rust field and constant to match.

Background

BEP 3 defines the ip parameter as an optional GET param. The Torrust Tracker currently uses peer_addr — a non-standard name not defined in any BEP.

Scope

  • Rename wire param peer_addrip throughout the HTTP protocol layer
  • Rename Rust struct field, builder method, extractor function, and constant
  • Fix incorrect NOTICE in packages/axum-http-server/src/lib.rs (wrongly claims BEP 15 origin)
  • Commit ADR: accept only IP addresses (not DNS names) in the ip parameter

Full spec: docs/issues/drafts/rename-peer-addr-to-ip-in-http-announce-request/ISSUE.md

Metadata

Metadata

Assignees

Labels

BugIncorrect Behavior

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions