Change default method to POST in emitter (close #289)#290
Merged
Jack Keene (Jack-Keene) merged 20 commits intoNov 3, 2022
Conversation
Jack Keene (Jack-Keene)
requested a review
from Matus Tomlein (matus-tomlein)
Snowplow CLA bot (snowplowcla)
added
the
cla:no
Jack Keene (Jack-Keene)
removed
the
cla:no
Matus Tomlein (matus-tomlein)
force-pushed
the
release/0.12.0
branch
from
316f873 to
fed98f8
Compare
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
Seems like there is an extra commit with changing the HTTPS default because we updated the release branch. You'll need to remove that from this branch, which is quite an annoying process, let me know if you need help.
Matus Tomlein (matus-tomlein)
force-pushed
the
issue/289_set_default_method_post
branch
from
298e71c to
09ef976
Compare
…snowplow/snowplow-python-tracker into issue/289_set_default_method_post
Jack Keene (Jack-Keene)
requested a review
from Matus Tomlein (matus-tomlein)
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
One more thing that I just realized is that the example app makes use of an Emitter with default configuration – I suppose that won't track any events since there are less than 10 events tracked... Can you add a flush at the end?
Jack Keene (Jack-Keene)
requested a review
from Matus Tomlein (matus-tomlein)
Matus Tomlein (matus-tomlein)
approved these changes
Nov 3, 2022
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Matus Tomlein (matus-tomlein)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the default method to post in the emitter as well as setting the Default buffer size to 1 (see discussion in issue 289). It also updates the tests to reflect the expected changes.