Make HTTPS the default protocol in emitter (close #14)#288
Merged
Jack Keene (Jack-Keene) merged 3 commits intoOct 31, 2022
Conversation
Jack Keene (Jack-Keene)
added
type:enhancement
Jack Keene (Jack-Keene)
requested a review
from Matus Tomlein (matus-tomlein)
Snowplow CLA bot (snowplowcla)
added
the
cla:no
Jack Keene (Jack-Keene)
removed
the
cla:no
Matus Tomlein (matus-tomlein)
approved these changes
Oct 31, 2022
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I just had a minor comment about the use of set.
Also can we rename the issue to something like Make HTTPS the default protocol in emitter. And make sure to use the # before issue number in the PR title (so ... (close #14), otherwise Github won't reference the commit to the issue when you merge the PR.
| protocol: HttpProtocol = "http", | ||
| protocol: HttpProtocol = "https", | ||
| port: Optional[int] = None, | ||
| method: Method = "get", |
Contributor
There was a problem hiding this comment.
Fyi, I think it would be good to move to POST as the default method, but I have a dilemma about the default buffer size that I think we should discuss a bit more. Wrote it down in the issue here.
Jack Keene (Jack-Keene)
changed the title
Jack Keene (Jack-Keene)
changed the title
Jack Keene (Jack-Keene)
added a commit
that referenced
this pull request
Nov 1, 2022
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes https default for the emitter protocol as well as allowing the protocol to be included in the url endpoint.