Add GitHub Actions CI #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sagarkarira the package-lock.json was not right in master either. The last patch I have here fixes it. Preview: https://github.com/XhmikosR/coronavirus-tracker-cli/runs/522111636 Note that this will run from the next PR for security reasons. |
Owner
|
Strange. I removed all node_modules and installed again. Still getting old
package-lock.json.
…On Fri, Mar 20, 2020 at 7:55 PM XhmikosR ***@***.***> wrote:
@sagarkarira <https://github.com/sagarkarira> the package-lock.json was
not right in master either. The last patch I have here fixes it. Preview:
https://github.com/XhmikosR/coronavirus-tracker-cli/runs/522111636
Note that this will run from the next PR for security reasons.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD6FLFE72QSKW3PBVZHERTRIN4GVANCNFSM4LPKJQAQ>
.
|
Contributor
Author
|
This fixes it for sure as you can see, since |
Owner
|
Great, I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs tests or ESLint so I'll rebase it after #30 :)