-
Notifications
You must be signed in to change notification settings - Fork 79
Add ESLint, remove dead code #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sagarkarira BTW if you'd like to add GitHub Actions CI support let me know and I'll make a new patch later :) |
|
Sorry, @XhmikosR I merged two PR today which had a lot of changes. Do you want to look at this again? |
|
@sagarkarira should be OK now. Personally I prefer using xo for linting, so let me know if you want me to switch to that in another PR. |
|
Thanks for contributing @XhmikosR ❤️ . |
|
Where's yargonaut used @sagarkarira ? |
|
It adds color to yargs commands. You just need to declare it top of yargs and it does this automatically. Check here |
|
Oh, OK. Then you missed the package-lock.json. If you fetch the latest master and do |
|
You are right. I pushed it.
…On Fri, Mar 20, 2020 at 7:46 PM XhmikosR ***@***.***> wrote:
Oh, OK. Then you missed the package-lock.json. If you fetch the latest
master and do npm i you will see the lock file is modified. After you
commit it ping me so that I proceed with the rest of the PRs :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD6FLH4QDIWBBN7P4LHIZLRIN3DZANCNFSM4LPI6GRA>
.
|
|
For what is worth, with #33 you'd see it before merging https://github.com/XhmikosR/coronavirus-tracker-cli/runs/522090935#step:6:6 |
Non-whitespace diff: https://github.com/sagarkarira/coronavirus-tracker-cli/pull/30/files?w=1