Skip to content

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Mar 19, 2020

@XhmikosR
Copy link
Contributor Author

@sagarkarira BTW if you'd like to add GitHub Actions CI support let me know and I'll make a new patch later :)

@XhmikosR XhmikosR mentioned this pull request Mar 19, 2020
@sagarkarira
Copy link
Owner

Sorry, @XhmikosR I merged two PR today which had a lot of changes. Do you want to look at this again?

@XhmikosR
Copy link
Contributor Author

@sagarkarira should be OK now. Personally I prefer using xo for linting, so let me know if you want me to switch to that in another PR.

@XhmikosR XhmikosR mentioned this pull request Mar 20, 2020
@XhmikosR XhmikosR mentioned this pull request Mar 20, 2020
@sagarkarira
Copy link
Owner

Thanks for contributing @XhmikosR ❤️ .

@sagarkarira sagarkarira reopened this Mar 20, 2020
@sagarkarira sagarkarira merged commit cf333fe into sagarkarira:master Mar 20, 2020
@XhmikosR
Copy link
Contributor Author

Where's yargonaut used @sagarkarira ?

@XhmikosR XhmikosR deleted the lint branch March 20, 2020 14:09
@sagarkarira
Copy link
Owner

It adds color to yargs commands. You just need to declare it top of yargs and it does this automatically. Check here

@XhmikosR
Copy link
Contributor Author

Oh, OK. Then you missed the package-lock.json. If you fetch the latest master and do npm i you will see the lock file is modified. After you commit it ping me so that I proceed with the rest of the PRs :)

@sagarkarira
Copy link
Owner

sagarkarira commented Mar 20, 2020 via email

@XhmikosR
Copy link
Contributor Author

For what is worth, with #33 you'd see it before merging https://github.com/XhmikosR/coronavirus-tracker-cli/runs/522090935#step:6:6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants