Add request builder#63
Merged
Merged
Conversation
Collaborator
|
@dheid Travis looks good! Give me some time to check the changes, but this looks awesome already. Any open issues that are already solved with this? |
Collaborator
Author
Collaborator
Author
Collaborator
Author
|
Okay, nothing more to fix or add at the moment. Review can start, @tholu |
Collaborator
Author
|
@tholu Friendly reminder (Just want to use the builder in one of my projects and waiting for your review) |
Collaborator
|
@dheid I'll try to get this reviewed (and ideally released on Maven central) by tomorrow evening! |
Collaborator
Author
|
@tholu Thanks so much!!! |
Collaborator
|
@dheid Release to Maven Central is on its way and should be there in the next hours. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tholu !
As announced, I did some enhancements to the Matomo Java Client library:
Old class names and methods will still be there. So most users should not be affected by the update. Nevertheless some things changed and I recommend to use major version 2.
Sorry for the large commit and the unreadable diff. There were some many things to do and I didn't have the time to do it incrementially. Builds are running on my machine, but I cannot use Travis. Perhaps it's a good idea to switch to GitHub Actions soon.
I hope you will merge this pull request! I think the enhancements are worth it.
Best wishes
Daniel