fix: TTL-898 tests

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

@@ -281,6 +281,21 @@ describe('EntryFieldsComponent', () => {
     expect(component.showTimeInbuttons).toEqual(false);
   });
 
+  fit('when a start hour is updated, but the entry is invalid, then do not dispatch UpdateActiveEntry', () => {
+    component.newData = mockEntryOverlap;
+    component.activeEntry = entry;
+    component.setDataToUpdate(entry);
+    const updatedTime = moment(mockDate).format('HH:mm');
+
+    component.entryForm.patchValue({ start_hour: updatedTime });
+    spyOn(store, 'dispatch');
+    spyOn(component, 'entryFormIsValidate').and.returnValue(entryForm.invalid);
+
+    component.onUpdateStartHour();
+
+    expect(store.dispatch).not.toHaveBeenCalled();
+  });
+
   it(
     'When start_time is updated, component.last_entry is equal to time entry in the position 1',
     waitForAsync(() => {
@@ -309,19 +324,6 @@ describe('EntryFieldsComponent', () => {
     expect(store.dispatch).toHaveBeenCalledTimes(1);
   });
 
-  it('When start_time is updated for an invalid time entry. UpdateCurrentOrLastEntry action is NOT dispatched', () => {
-    component.newData = mockEntryOverlap;
-    component.activeEntry = entry;
-    component.setDataToUpdate(entry);
-    const updatedTime = moment(mockDate).subtract(4, 'hours').format('HH:mm');
-    component.entryForm.patchValue({ start_hour: updatedTime });
-    spyOn(store, 'dispatch');
-
-    component.onUpdateStartHour();
-
-    expect(store.dispatch).toHaveBeenCalledTimes(1);
-  });
-
   it('when a technology is added or removed, then dispatch UpdateActiveEntry', () => {
     const addedTechnologies = ['react'];
     const isEntryFormValid = spyOn(component, 'entryFormIsValidate').and.returnValue(true);
@@ -586,18 +588,5 @@ describe('EntryFieldsComponent', () => {
     expect(store.dispatch).not.toHaveBeenCalled();
   });
 
-  it('do not display an error message when trying to updateStartHour, with no description and no ticket and it is an external app', () => {
-    component.newData = entry;
-    component.activeEntry = entry;
-    component.setDataToUpdate(entry);
-    spyOn(toastrServiceStub, 'error');
-
-    const hour = moment(mockDate).add(4, 'hour').format('HH:mm');
-    component.entryForm.patchValue({ start_hour: hour, description: '',  uri: '', customer_name: 'Warby' });
-    component.onUpdateStartHour();
-
-    expect(toastrServiceStub.error).not.toHaveBeenCalled();
-  });
-
 });
 

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

@@ -210,7 +210,7 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
     this.actionSetDateSubscription.unsubscribe();
   }
 
-  requiredFieldsForInternalAppExist(customerName, projectName) {
+  requiredFieldsForInternalAppExist(customerName: string, projectName: string) {
     const emptyValue = '';
     const areEmptyValues = [this.entryForm.value.uri, this.entryForm.value.description].every(
       (item) => item === emptyValue