Ttl 898 fix bug that lets you save without required fields #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
| expect(autofocus).toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
| // it('when a activity is not register in DB should show activatefocus in select activity', () => { |
There was a problem hiding this comment.
why this code is commented?
There was a problem hiding this comment.
it was not working in the first place, it expects something that is not a function to have been called
thegreatyamori
approved these changes
Jul 10, 2023
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
|
Kudos, SonarCloud Quality Gate passed!
|
mmaquina
deleted the
TTL-898-fix-bug-that-lets-you-save-without-required-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent home page from sending the form when required fields are missing.
Fix existing tests.
Files changed
Task board
Acceptance criteria
Should not let time entries be saved by updating time in, or technologies in the home pages if required fields are not filled.