Skip to content

887 validate required fields for internal apps #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 6, 2023
Merged

887 validate required fields for internal apps #990

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d18f521
refactor: TTL-887 validate required fields for internal apps
mmaquina May 30, 2023
484326f
fix: TTL-887 make if condition more readable
mmaquina May 30, 2023
cc9339c
test: TTL-887 tests for saving time entries
mmaquina May 30, 2023
a88f38c
refactor: TTL-887 improve tests
Santiago220991 May 31, 2023
2c9a164
refactor: TTL-887 english lessons and safari books can skip descripti…
mmaquina May 31, 2023
0dfddd2
refactor: TTL-887 improve tests
Santiago220991 May 31, 2023
ae5b22f
feat: TTL-887 move constants to a shared file
Santiago220991 May 31, 2023
b8f23e6
refactor: TTL-887 import constants from a shared file
Santiago220991 May 31, 2023
a6a76f3
fix: TTL-887 Activity is required toastr
mmaquina Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TTL-887 improve tests
  • Loading branch information
@Santiago220991
Santiago220991 committed May 31, 2023
commit 0dfddd2a33950a1dea5d2a4e85b8a59d0049111d
9 changes: 2 additions & 7 deletions src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,14 +744,13 @@ describe('DetailsFieldsComponent', () => {

component.onSubmit();
expect(toastrServiceStub.warning).not.toHaveBeenCalled();

expect(component.saveEntry.emit).toHaveBeenCalled();
});

it('should not display a warning message when trying to save time entry of external customer without required fields and save', () => {
component.entryForm.setValue({ ...entryWithoutRequiredFields, project_name: 'Warby Parker' });
spyOn(toastrServiceStub, 'warning');
spyOn(component.saveEntry, 'emit');
spyOn(toastrServiceStub, 'warning');

component.onSubmit();
expect(toastrServiceStub.warning).not.toHaveBeenCalled();
Expand All @@ -761,20 +760,17 @@ describe('DetailsFieldsComponent', () => {

it('should not display a warning message when trying to save time entry of internal app with description and save', () => {
component.entryForm.setValue({ ...entryWithoutRequiredFields, description: 'Description' });

spyOn(toastrServiceStub, 'warning');
spyOn(component.saveEntry, 'emit');
spyOn(toastrServiceStub, 'warning');

component.onSubmit();
expect(toastrServiceStub.warning).not.toHaveBeenCalled();

expect(component.saveEntry.emit).toHaveBeenCalled();
});

/* We allow saving time entries with empty fields in uri and description for safari books and english lessons */
it('should not display a warning message when trying to save time entry of English Lessons without description and save', () => {
component.entryForm.setValue({ ...entryWithoutRequiredFields, project_name: 'ioet inc. - English Lessons' });

spyOn(toastrServiceStub, 'warning');
spyOn(component.saveEntry, 'emit');

Expand All @@ -784,7 +780,6 @@ describe('DetailsFieldsComponent', () => {
expect(component.saveEntry.emit).toHaveBeenCalled();
});


/*
TODO As part of https://github.com/ioet/time-tracker-ui/issues/424 a new parameter was added to the details-field-component,
and now these couple of tests are failing. A solution to this error might be generate a Test Wrapper Component. More details here:
Expand Down