Skip to content

Conversation

mmaquina
Copy link
Contributor

@mmaquina mmaquina commented May 30, 2023

Description

Add validation when saving time entries of internal projects. They must have a description or a ticket name(uri).

Files changed

  • src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
  • src/app/modules/shared/components/details-fields/details-fields.component.ts
  • src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
  • src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
  • src/app/modules/shared/messages.ts
  • src/app/modules/shared/internal-app-constants.ts

Task board

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @Santiago220991, Action: `pull_request`*

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@Santiago220991 Santiago220991 merged commit cadff0d into master Jun 6, 2023
@Santiago220991 Santiago220991 deleted the 887-validate-required-fields-for-internal-apps branch June 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants