Skip to content

Tta 189 create an anchor for the edit a customer action #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Tta 189 create an anchor for the edit a customer action #953

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c893bc0
noworking commit
mmaquina Oct 17, 2022
c60b9aa
Merge branch 'master' into TTA-189-create-an-anchor-for-the-edit-a-cu…
mmaquina Nov 18, 2022
ad2c9d5
refactor: TTA-189 dropped unused function
mmaquina Nov 18, 2022
1a4daa9
refactor: TTA-189 dropped another unused function
mmaquina Nov 18, 2022
a1943e0
refactor: TTA-189 erased test
mmaquina Nov 23, 2022
833d715
refactor: TTA-189 scrollToCustomerForm
mmaquina Nov 24, 2022
2c4fce2
refactor: TTA-189 scrollToCustomer
mmaquina Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TTA-189 erased test 
Test erased for case being already covered in separate existing test.
  • Loading branch information
@mmaquina
mmaquina committed Nov 23, 2022
commit a1943e05208ef46ef91a97ec39267962a4dcd57d
13 changes: 1 addition & 12 deletions ...agement/components/customer-info/components/customer-list/customer-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('CustomerTableListComponent', () => {
expect(component.showModal).toBeTrue();
});

it('onClick edit, if there are no unsaved changes dispatch SetCustomerToEdit, enable customer form and hidden modal', () => {
it('onClick edit, if there are no unsaved changes dispatch SetCustomerToEdit, enable customer form and hide modal', () => {
component.hasChange = false;

spyOn(store, 'dispatch');
Expand All @@ -104,17 +104,6 @@ describe('CustomerTableListComponent', () => {
expect(component.showModal).toBeFalse();
});

it('onClick edit, if there are no unsaved changes customer edit form should be visible', () => {
component.hasChange = false;

spyOn(store, 'dispatch');

component.editCustomer('1');
const bottomElement = document.getElementById('bottom');
expect(bottomElement).toBeTrue();

});

it('onClick edit, dispatch clean Forms in project and project type', () => {
spyOn(store, 'dispatch');

Expand Down