Skip to content

Tta 189 create an anchor for the edit a customer action #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Tta 189 create an anchor for the edit a customer action #953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c893bc0
noworking commit
mmaquina Oct 17, 2022
c60b9aa
Merge branch 'master' into TTA-189-create-an-anchor-for-the-edit-a-cu…
mmaquina Nov 18, 2022
ad2c9d5
refactor: TTA-189 dropped unused function
mmaquina Nov 18, 2022
1a4daa9
refactor: TTA-189 dropped another unused function
mmaquina Nov 18, 2022
a1943e0
refactor: TTA-189 erased test
mmaquina Nov 23, 2022
833d715
refactor: TTA-189 scrollToCustomerForm
mmaquina Nov 24, 2022
2c4fce2
refactor: TTA-189 scrollToCustomer
mmaquina Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TTA-189 dropped another unused function
  • Loading branch information
@mmaquina
mmaquina committed Nov 18, 2022
commit 1a4daa95f467803dbdd452cb7515268ee789ce17
22 changes: 0 additions & 22 deletions ...r-management/components/customer-info/components/customer-list/customer-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,26 +206,4 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
element.scrollIntoView();
}


waitForForm() {
const selector = 'customerFormDiv';
return new Promise(resolve => {
if (document.querySelector(selector)) {
return resolve(document.querySelector(selector));
}

const observer = new MutationObserver(mutations => {
if (document.querySelector(selector)) {
resolve(document.querySelector(selector));
observer.disconnect();
}
});

observer.observe(document.body, {
childList: true,
subtree: true
});
});
}

}
1 change: 0 additions & 1 deletion src/app/modules/customer-management/pages/customer.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,4 @@ describe('CustomerComponent', () => {

expect(component.hasChangeComponent).toBe(true);
});

});
2 changes: 1 addition & 1 deletion src/app/modules/customer-management/pages/customer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class CustomerComponent {
}

scrollToCustomerForm(): void {
const element = document.getElementById("bottom");
const element = document.getElementById('bottom');
element.scrollIntoView();
}
}