Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TTA-115 fix code smells
  • Loading branch information
Abigail Cabascango committed Oct 6, 2022
commit 2e9e2cb40088a45c0061e0754f98c8c2aff87da1
2 changes: 0 additions & 2 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ import { FastDirective} from './modules/internet-connection-status/internet-conn
import { SlowDirective} from './modules/internet-connection-status/internet-connection-directives/slow.directive';
import { OfflineDirective} from './modules/internet-connection-status/internet-connection-directives/offline.directive';
import { ConnectionDirective } from './modules/internet-connection-status/internet-connection-directives/connection.directive';
import { ToastrService } from 'ngx-toastr';

const maskConfig: Partial<IConfig> = {
validation: false,
Expand Down Expand Up @@ -219,7 +218,6 @@ const maskConfig: Partial<IConfig> = {
},
DatePipe,
CookieService,
ToastrService,
{provide: Window, useValue: window}
],
bootstrap: [AppComponent],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Component, OnInit, ContentChild, Attribute, OnDestroy} from '@angular/core';
import { Component, OnInit, ContentChild, Attribute} from '@angular/core';
import { FastDirective} from '../../modules/internet-connection-status/internet-connection-directives/fast.directive';
import { SlowDirective} from '../../modules/internet-connection-status/internet-connection-directives/slow.directive';
import { OfflineDirective} from '../../modules/internet-connection-status/internet-connection-directives/offline.directive';
import { Observable, of, Subscription } from 'rxjs';
import { take, map } from 'rxjs/operators';
import { Observable, Subscription } from 'rxjs';
import { take } from 'rxjs/operators';
import { ToastrService } from 'ngx-toastr';

type Connection = {
Expand All @@ -23,8 +23,7 @@ declare global {

@Component({
selector: 'app-internet-connection-status',
templateUrl: './internet-connection-status.component.html',
styleUrls: ['./internet-connection-status.component.scss']
templateUrl: './internet-connection-status.component.html'
})
export class InternetConnectionStatusComponent implements OnInit {
isFast = true;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { TestBed } from '@angular/core/testing';
import * as assert from 'assert';
import { catchError, map, mergeMap } from 'rxjs/operators';
import { catchError } from 'rxjs/operators';
import { IndividualConfig, ToastrService } from 'ngx-toastr';
import { StatusNetworkService } from './status-network.service';

Expand Down
5 changes: 0 additions & 5 deletions src/app/modules/users/store/user.effects.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export class UserEffects {
}),
catchError((error) => {
this.statusNetworkService.checkTypeError({error, isError: true});
//this.toastrService.error(error.error.message);
return of(new actions.LoadUsersFail(error));
})
)
Expand All @@ -47,7 +46,6 @@ export class UserEffects {
}),
catchError((error) => {
this.statusNetworkService.checkTypeError({error, isError: true});
//this.toastrService.error(error.error.message);
return of(new actions.AddUserToGroupFail(error));
})
)
Expand All @@ -66,7 +64,6 @@ export class UserEffects {
}),
catchError((error) => {
this.statusNetworkService.checkTypeError({error, isError: true});
//this.toastrService.error(error.error.message);
return of(new actions.RemoveUserFromGroupFail(error));
})
)
Expand All @@ -85,7 +82,6 @@ export class UserEffects {
}),
catchError((error) => {
this.statusNetworkService.checkTypeError({error, isError: true});
//this.toastrService.error(error.error.message);
return of(new actions.GrantUserRoleFail(error));
})
)
Expand All @@ -104,7 +100,6 @@ export class UserEffects {
}),
catchError((error) => {
this.statusNetworkService.checkTypeError({error, isError: true});
//this.toastrService.error(error.error.message);
return of(new actions.RevokeUserRoleFail(error));
})
)
Expand Down
3 changes: 2 additions & 1 deletion src/environments/environment.prodlegacy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { EnvironmentType } from './enum';

export const environment = {
production: EnvironmentType.TT_PROD_LEGACY,
timeTrackerApiUrl: process.env["API_URL"],
//timeTrackerApiUrl: process.env["API_URL"],
timeTrackerApiUrl:'https://a9e7-190-231-230-97.sa.ngrok.io',
stackexchangeApiUrl: 'https://api.stackexchange.com',
};

Expand Down