Skip to content

TTA 115 time tracker doesnt notifies the user when they lost internet connection or have a slow connection #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

TTA 115 time tracker doesnt notifies the user when they lost internet connection or have a slow connection #928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d0c5298
TTA-115 implement a stable, slow or offline connection warning
Aug 22, 2022
e04763f
TTA-115 implement a stable, slow or offline connection warning
Aug 22, 2022
b56113b
TTA-115 rebase master
Aug 29, 2022
84bde1c
TTA-115 Refactor end points
Sep 6, 2022
da0522a
feat: TTA-115 implement notification when the endpoint fails for a sl…
Sep 12, 2022
4665966
refactor: TTA-115 the if clausses in status network service and conne…
Oct 5, 2022
07809f5
refactor: TTA-115 create unit test for function checkTypeError in sta…
Oct 6, 2022
fe5b055
refactor: TTA-115 unit test for function checkTypeError in status net…
Oct 6, 2022
1d40b7d
refactor: TTA-115 fix linters errors
Oct 6, 2022
5f65148
refactor: TTA-115 increase test coverage in status network service
Oct 6, 2022
a912865
refactor: TTA-115 increase test coverage in directives
Oct 6, 2022
940f4b8
refactor: TTA-115 solve github comment
Oct 6, 2022
470a043
fix: TTA-115 Merge master into TTA-115
Oct 6, 2022
5f8aac5
Merge remote-tracking branch 'origin/master' into TTA-115-time-tracke…
Oct 6, 2022
2e9e2cb
fix: TTA-115 fix code smells
Oct 6, 2022
e88247c
fix: change API URL in prod :'v
Oct 6, 2022
37cec9b
Update src/app/modules/internet-connection-status/internet-connection…
Yalian Oct 7, 2022
8e72487
refactor: TTA-115 solve review comments
Oct 7, 2022
5bc7915
refactor: TTA-115 solve linting
Oct 7, 2022
aabefaf
refactor: TTA-115 changed test descriptions - lint
mmaquina Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TTA-115 fix linters errors
  • Loading branch information
Abigail Cabascango committed Oct 6, 2022
commit 1d40b7d7e1948ea6dec8bfaff7d53fb8728bff57
3 changes: 1 addition & 2 deletions ...modules/internet-connection-status/internet-connection-directives/connection.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ export class ConnectionDirective implements OnInit {
let networkSatus;
if (!(/\fast-5g|3g|4g/.test(effectiveType)) || !(/\slow-2g|2g/.test(effectiveType))){
networkSatus = this.offlineSrc;
return
}

if (/\fast-5g|3g|4g/.test(effectiveType)) {
networkSatus = this.fastSrc;
}

if (/\slow-2g|2g/.test(effectiveType)) {
networkSatus = this.slowSrc;
}
Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/internet-connection-status/internet-connection-status.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class InternetConnectionStatusComponent implements OnInit {
.subscribe((effectiveType: string) => {

this.connectionType = effectiveType;

if (!(/\fast-5g|3g|4g/.test(effectiveType)) || !(/\slow-2g|2g/.test(effectiveType))){
this.toastrService.error('Your request was not completed, you are offline');
this.isFast = false;
Expand Down