Skip to content

Conversation

@OscarPallazhco
Copy link
Collaborator

@OscarPallazhco OscarPallazhco commented Jan 20, 2022

In this PR the endpoint created for reports is used. In production it will not change the route.

Working in local
Screenshot from 2022-01-20 13-59-28

Working in production
Screenshot from 2022-01-20 13-29-51

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.0% 50.0% Duplication

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #797 (3378a78) into master (95d1ed3) will increase coverage by 0.13%.
The diff coverage is 96.50%.

❗ Current head 3378a78 differs from pull request most recent head 9780430. Consider uploading reports for the commit 9780430 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   95.64%   95.78%   +0.13%     
==========================================
  Files         107      107              
  Lines        2273     2418     +145     
  Branches      175      203      +28     
==========================================
+ Hits         2174     2316     +142     
+ Misses         54       53       -1     
- Partials       45       49       +4     
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/app/modules/time-clock/store/entry.effects.ts 96.29% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...eate-project-type/create-project-type.component.ts 96.96% <50.00%> (-3.04%) ⬇️
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...c/app/modules/time-clock/services/entry.service.ts 96.42% <75.00%> (-3.58%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 89.28% <83.33%> (-2.39%) ⬇️
...ts/projects/components/services/project.service.ts 88.23% <85.71%> (-2.68%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb304c0...9780430. Read the comment docs.

Copy link

@madinya madinya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@OscarPallazhco OscarPallazhco merged commit 5d29b8e into master Jan 20, 2022
@OscarPallazhco OscarPallazhco deleted the TT-501-Integrate-reports-with-the-new-Backend branch January 20, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants