Skip to content

Commit 5d29b8e

Browse files
Tt 501 integrate reports with the new backend (#797)
* refactor: TT-501 change of route * refactor: TT-501 change of name of route * refactor: TT-501 just change the url when in development Co-authored-by: Davcg5 <[email protected]>
1 parent fb304c0 commit 5d29b8e

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/app/modules/time-clock/services/entry.service.spec.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ describe('EntryService', () => {
105105
const pipe: DatePipe = new DatePipe('en');
106106
const timeRange: TimeEntriesTimeRange = {start_date: yesterday, end_date: today};
107107
const userId = '123';
108-
108+
const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
109109
service.loadEntriesByTimeRange(timeRange, userId).subscribe();
110110

111-
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === service.baseUrl);
111+
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === reportsUrl);
112112
expect(loadEntryRequest.request.params.get('start_date')).toBe(pipe.transform(yesterday,
113113
EntryService.TIME_ENTRIES_DATE_TIME_FORMAT));
114114
expect(loadEntryRequest.request.params.get('end_date')).toBe(pipe.transform(today, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT));
@@ -120,10 +120,10 @@ describe('EntryService', () => {
120120
const today = moment(new Date());
121121
const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
122122
const userId = '123';
123-
123+
const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
124124
service.loadEntriesByTimeRange(timeRange, userId).subscribe();
125125

126-
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === service.baseUrl);
126+
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === reportsUrl);
127127
expect(loadEntryRequest.request.params.get('limit')).toEqual('9999');
128128
});
129129

@@ -132,10 +132,11 @@ describe('EntryService', () => {
132132
const today = moment(new Date());
133133
const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
134134
const userId = '123';
135+
const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
135136

136137
service.loadEntriesByTimeRange(timeRange, userId).subscribe();
137138

138-
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === service.baseUrl);
139+
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === reportsUrl);
139140

140141
const timezoneOffset = new Date().getTimezoneOffset().toString();
141142
expect(loadEntryRequest.request.params.get('timezone_offset')).toEqual(timezoneOffset);

src/app/modules/time-clock/services/entry.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ export class EntryService {
6868

6969
loadEntriesByTimeRange(range: TimeEntriesTimeRange, userId: string): Observable<any> {
7070
const MAX_NUMBER_OF_ENTRIES_FOR_REPORTS = 9999;
71-
return this.http.get(this.baseUrl,
71+
const loadEntriesByTimeRangeURL = this.urlInProduction ? this.baseUrl : this.baseUrl + '/report';
72+
return this.http.get(loadEntriesByTimeRangeURL,
7273
{
7374
params: {
7475
start_date: this.datePipe.transform(range.start_date, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT),

0 commit comments

Comments
 (0)