Skip to content

fix: TT-477 customer change status #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2022
Merged

fix: TT-477 customer change status #787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59968ce
fix: TT-477 customer change status
Davcg5 Dec 30, 2021
1215f18
refactor: TT-477 change of name of variable
Davcg5 Dec 30, 2021
4df5fec
refactor: TT-477 based on scastillo-jp comments
Davcg5 Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TT-477 change of name of variable
  • Loading branch information
@Davcg5
Davcg5 committed Dec 30, 2021
commit 1215f180dd078d1711c1ab8b84aa3a5f4840c02b
2 changes: 1 addition & 1 deletion ...agement/components/customer-info/components/customer-list/customer-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ describe('CustomerTableListComponent', () => {
it('changeStatus should set inactive whan active', () => {

Copy link
Collaborator

@scastillo-jp scastillo-jp Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this white line

component.changeStatus();
expect(component.status === 'inactive');
expect(component.statusToEdit === 'inactive');
});


Expand Down
6 changes: 3 additions & 3 deletions ...r-management/components/customer-info/components/customer-list/customer-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
showModal = false;
idToDelete: string;
idToEdit: string;
status: string;
statusToEdit: string;
currentCustomerIdToEdit: string;
message: string;
isLoading$: Observable<boolean>;
Expand Down Expand Up @@ -171,7 +171,7 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {

openModal(item: Customer) {
this.idToDelete = item.id;
this.status = item.status;
this.statusToEdit = item.status;
this.message = `Are you sure you want to disable ${item.name}?`;
this.showModal = true;
}
Expand All @@ -196,7 +196,7 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
}

changeStatus(): void{
this.store.dispatch(new UnarchiveCustomer(this.idToDelete, this.changeOppositeStatus(this.status)));
this.store.dispatch(new UnarchiveCustomer(this.idToDelete, this.changeOppositeStatus(this.statusToEdit)));
}

}