-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-477 customer change status #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
+ Coverage 95.64% 95.86% +0.21%
==========================================
Files 107 107
Lines 2273 2416 +143
Branches 175 201 +26
==========================================
+ Hits 2174 2316 +142
+ Misses 54 53 -1
- Partials 45 47 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check if this works in production
...er-management/components/customer-info/components/customer-list/customer-list.component.html
Show resolved
Hide resolved
...omer-management/components/customer-info/components/customer-list/customer-list.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/customer-management/store/customer-management.effects.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments to format the code
| } | ||
| changeOppositeStatus(status: string): string{ | ||
| return status === 'inactive' ? 'active' : 'inactive'; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this white line
|
|
||
|
|
||
| it('changeStatus should set inactive whan active', () => { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this white line
| } else { | ||
| this.showModal = false; | ||
| this.store.dispatch(new UnarchiveCustomer(item.id)); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this white line
| setActive(status: any): string { | ||
| return status === 'inactive' ? 'inactive' : 'active'; | ||
| } | ||
| changeOppositeStatus(status: string): string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space before {
string {
Includes fix of a typo
|
Kudos, SonarCloud Quality Gate passed!
|








The change of status is calling now to the update instead of the delete.