Skip to content

Conversation

@Davcg5
Copy link
Collaborator

@Davcg5 Davcg5 commented Dec 30, 2021

The change of status is calling now to the update instead of the delete.

Screen Shot 2021-12-30 at 12 34 44

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #787 (988db11) into master (95d1ed3) will increase coverage by 0.21%.
The diff coverage is 97.33%.

❗ Current head 988db11 differs from pull request most recent head 4df5fec. Consider uploading reports for the commit 4df5fec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   95.64%   95.86%   +0.21%     
==========================================
  Files         107      107              
  Lines        2273     2416     +143     
  Branches      175      201      +26     
==========================================
+ Hits         2174     2316     +142     
+ Misses         54       53       -1     
- Partials       45       47       +2     
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/app/modules/time-clock/store/entry.effects.ts 96.29% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 89.28% <83.33%> (-2.39%) ⬇️
...ts/projects/components/services/project.service.ts 88.23% <85.71%> (-2.68%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.17% <96.29%> (-0.23%) ⬇️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7c26d...4df5fec. Read the comment docs.

Copy link
Collaborator

@ararcos ararcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if this works in production

Copy link
Collaborator

@scastillo-jp scastillo-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to format the code

}
changeOppositeStatus(status: string): string{
return status === 'inactive' ? 'active' : 'inactive';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this white line



it('changeStatus should set inactive whan active', () => {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this white line

} else {
this.showModal = false;
this.store.dispatch(new UnarchiveCustomer(item.id));

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this white line

setActive(status: any): string {
return status === 'inactive' ? 'inactive' : 'active';
}
changeOppositeStatus(status: string): string{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space before {
string {

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Davcg5 Davcg5 merged commit fcdc46a into master Jan 3, 2022
@Davcg5 Davcg5 deleted the TT-477-Change-Customers-Visibility branch January 3, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants