Skip to content

Conversation

@EdansRocks
Copy link
Contributor

Problem

Currently the ng-autocomplete component is used to select the projects in the Time Clock and Time entries section, which stores in Local Storage the history of recent projects that have been selected, which generates problems because it may happen that a project is deactivated but as it is stored in Local Storage the users can still do Clock In. Previously a patch was made to synchronize these projects in Local Storage with the server projects.
image

Solution

An endpoint was created in the backend to obtain the recent projects of each user according to the last 20 entries, given this the solution is to replace the ng-autocomplete component that uses the Local Storage to consume the information from the backend endpoint, replacing the previous functionality.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #753 (5ec2ec2) into master (95d1ed3) will increase coverage by 0.05%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   95.64%   95.69%   +0.05%     
==========================================
  Files         107      106       -1     
  Lines        2273     2302      +29     
  Branches      175      179       +4     
==========================================
+ Hits         2174     2203      +29     
+ Misses         54       52       -2     
- Partials       45       47       +2     
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.reducer.ts 83.33% <100.00%> (+0.98%) ⬆️
...nts/projects/components/store/project.selectors.ts 71.42% <100.00%> (+4.76%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b50b6c...5ec2ec2. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@JosueOb JosueOb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already reviewed the changes made and tested them in the local environment with test data in the database to test their functionality. So I was able to get the projects from an endpoint and be submitted in the input of the time entry form. Good work @EdansRocks .

@EdansRocks EdansRocks merged commit 02cb07b into master Sep 21, 2021
@EdansRocks EdansRocks deleted the TT-327-Replace-recently-projects branch September 21, 2021 16:34
bytesantiago added a commit that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants