refactor: TT-327 Solving code smells from sonarcloud

Author: Andrés Soto

src/app/modules/customer-management/components/projects/components/store/project.actions.ts

@@ -8,7 +8,6 @@ export enum ProjectActionTypes {
   LOAD_CUSTOMER_PROJECTS = '[Projects] LOAD_CUSTOMER_PROJECTS',
   LOAD_CUSTOMER_PROJECTS_SUCCESS = '[Projects] LOAD_CUSTOMER_PROJECTS_SUCCESS',
   LOAD_CUSTOMER_PROJECTS_FAIL = '[Projects] LOAD_CUSTOMER_PROJECTS_FAIL',
-  LOAD_RECENT_PROJECTS = '[Projects] LOAD_RECENT_PROJECTS',
   LOAD_RECENT_PROJECTS_SUCCESS = '[Projects] LOAD_RECENT_PROJECTS_SUCCESS',
   LOAD_RECENT_PROJECTS_FAIL = '[Projects] LOAD_RECENT_PROJECTS_FAIL',
   CREATE_PROJECT = '[Projects] CREATE_PROJECT',
@@ -63,11 +62,6 @@ export class LoadCustomerProjectsFail implements Action {
   constructor(public error: string) {}
 }
 
-export class LoadRecentProjects implements Action {
-  public readonly type = ProjectActionTypes.LOAD_RECENT_PROJECTS;
-  constructor() {}
-}
-
 export class LoadRecentProjectsSuccess implements Action {
   readonly type = ProjectActionTypes.LOAD_RECENT_PROJECTS_SUCCESS;
   constructor(readonly payload: Project[]) {}
@@ -168,7 +162,6 @@ export type ProjectActions =
   | LoadCustomerProjects
   | LoadCustomerProjectsSuccess
   | LoadCustomerProjectsFail
-  | LoadRecentProjects
   | LoadRecentProjectsSuccess
   | LoadRecentProjectsFail
   | CreateProject

src/app/modules/customer-management/components/projects/components/store/project.effects.spec.ts

@@ -56,7 +56,7 @@ describe('ProjectEffects', () => {
   });
 
   it('action type is LOAD_RECENT_PROJECTS_SUCCESS when service is executed sucessfully', async () => {
-    actions$ = of({ type: ProjectActionTypes.LOAD_RECENT_PROJECTS });
+    actions$ = of({ type: ProjectActionTypes.LOAD_PROJECTS });
     const serviceSpy = spyOn(service, 'getRecentProjects');
     serviceSpy.and.returnValue(of(projects));
 
@@ -66,7 +66,7 @@ describe('ProjectEffects', () => {
   });
 
   it('action type is LOAD_RECENT_PROJECTS_FAIL when service fail in execution', async () => {
-    actions$ = of({ type: ProjectActionTypes.LOAD_RECENT_PROJECTS });
+    actions$ = of({ type: ProjectActionTypes.LOAD_PROJECTS });
     const serviceSpy = spyOn(service, 'getRecentProjects');
     serviceSpy.and.returnValue(throwError({ error: { message: 'fail!' } }));
     spyOn(toastrService, 'error');

src/app/modules/customer-management/components/projects/components/store/project.effects.ts

@@ -51,7 +51,7 @@ export class ProjectEffects {
 
   @Effect()
   loadRecentProjects$: Observable<Action> = this.actions$.pipe(
-    ofType(actions.ProjectActionTypes.LOAD_RECENT_PROJECTS),
+    ofType(actions.ProjectActionTypes.LOAD_PROJECTS),
     mergeMap(() =>
       this.projectService.getRecentProjects().pipe(
         map((projects) => {

src/app/modules/customer-management/components/projects/components/store/project.reducer.spec.ts

@@ -40,12 +40,6 @@ describe('projectReducer', () => {
     expect(state.customerProjects).toEqual([]);
   });
 
-  it('on LoadRecentProjects, isLoading is true', () => {
-    const action = new actions.LoadRecentProjects();
-    const state = projectReducer(initialState, action);
-    expect(state.isLoading).toEqual(true);
-  });
-
   it('on LoadRecentProjectsSuccess, projectsFound are saved in the store', () => {
     const projectsFound: Project[] = [{ id: '1', name: 'abc', description: 'xxx', status: 'active' }];
     const newState = initialState;

src/app/modules/customer-management/components/projects/components/store/project.reducer.ts

@@ -67,12 +67,6 @@ export const projectReducer = (state: ProjectState = initialState, action: Proje
       };
     }
 
-    case ProjectActionTypes.LOAD_RECENT_PROJECTS: {
-      return {
-        ...state,
-        isLoading: true,
-      };
-    }
     case ProjectActionTypes.LOAD_RECENT_PROJECTS_SUCCESS:
       return {
         ...state,

src/app/modules/shared/components/details-fields/details-fields.component.spec.ts

@@ -22,6 +22,7 @@ import { NgxMaterialTimepickerModule } from 'ngx-material-timepicker';
 
 import { DATE_FORMAT } from 'src/environments/environment';
 import { DATE_FORMAT_YEAR } from 'src/environments/environment';
+import { Project } from '../../models';
 
 describe('DetailsFieldsComponent', () => {
   type Merged = TechnologyState & ProjectState & EntryState;
@@ -155,13 +156,22 @@ describe('DetailsFieldsComponent', () => {
   });
 
   it('onClearedComponent project id and name are set to empty', () => {
-    const search = {term: '', items: []};
+    const search = {term: ''};
     component.onClearedComponent(search);
 
     expect(component.project_id.value).toBe('');
     expect(component.project_name.value).toBe('');
   });
 
+  it('should change the listProjectsShowed to listProjects if search is not empty on onClearedComponent', () => {
+    const search = {term: 'Ioet Inc.'};
+    const listProjects: Project[] = [{ id: '1', name: 'abc', status: 'active' }];
+    component.listProjects = listProjects;
+    component.onClearedComponent(search);
+
+    expect(component.listProjectsShowed).toBe(component.listProjects);
+  });
+
   it('onSelectedProject project id and name are set using event data', () => {
     spyOn(component.entryForm, 'patchValue');
 

src/app/modules/shared/components/details-fields/details-fields.component.ts

@@ -158,7 +158,7 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
   }
 
   getRecentProjects(): void {
-    this.store.dispatch(new projectActions.LoadRecentProjects());
+    this.store.dispatch(new projectActions.LoadProjects());
     const recentProjects$ = this.store.pipe(select(getRecentProjects));
     recentProjects$.subscribe((projects) => {
       if (projects) {

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

@@ -68,7 +68,7 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
       this.activities = response;
     });
 
-    this.store.dispatch(new actions.LoadRecentProjects());
+    this.store.dispatch(new actions.LoadProjects());
     const recentProjects$ = this.store.pipe(select(getRecentProjects));
     this.recentProjectsSubscription = recentProjects$.subscribe((projects) => {
       if (projects) {