fix: TT-216 add tabIndex attribute to materialDatePicker and to Date … #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytesantiago
requested review from
EdansRocks,
JosueOb,
edgardavid2015 and
scastillo-jp
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 95.54% 95.55%
=======================================
Files 106 106
Lines 2247 2250 +3
Branches 169 169
=======================================
+ Hits 2147 2150 +3
Misses 57 57
Partials 43 43
Continue to review full report at Codecov.
|
EdansRocks
approved these changes
Sep 7, 2021
edgardavid2015
approved these changes
Sep 7, 2021
bytesantiago
deleted the
TT-216-On-time-entries-page-when-creating-time-entry-Tab-gets-stuck-in-date-fields
branch
JosueOb
added a commit
that referenced
this pull request
Sep 13, 2021
* style: TT-332 include Tailwind in global style file * feat: TT-332 dark mode implementation * style: TT-332 color palette * test: TT-332 unit test on the dark mode component * fix: TT-216 add tabIndex attribute to materialDatePicker and to Date divs (#747) * chore(release): 1.50.5 [skip ci]nn * refactor: TT-332 application of Azure toggle function to display dark mode * style: TT-332 TW prefix added to the color palette * refactor: TT-332 changes in sidebar and dark mode components * fix: TT-334 keep the sidebar item selected when the page is refreshed (#748) * chore(release): 1.50.6 [skip ci]nn * refactor: TT-332 changes to the button to change the page theme * test: TT-332 unit test to check if the user has the dark-mode feature toggle enabled * style: TT-332 include Tailwind in global style file * feat: TT-332 dark mode implementation * style: TT-332 color palette * test: TT-332 unit test on the dark mode component * refactor: TT-332 application of Azure toggle function to display dark mode * style: TT-332 TW prefix added to the color palette * refactor: TT-332 changes in sidebar and dark mode components * refactor: TT-332 changes to the button to change the page theme * test: TT-332 unit test to check if the user has the dark-mode feature toggle enabled * refactor: TT-332 changes in the unit test description of the dark mode component and style name of the sidebar component Co-authored-by: Santiago Pozo Ruiz <[email protected]> Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At the time-entries tab, when trying to create a new time entry (or modify existing one), and using the tab key to move between fields, when you’re in the date field, hitting the tab key doesn’t do anything and you have to use your mouse to select the next field.
Solution
The "tabIndex" was added to the materialDatePicker which is the tool used for date and time selection, this allows us to navigate through the entry using the tab key. However, it is necessary to notice that we will not be able to actually modify the date itself, just the time; this is caused because the component property works as such.