Skip to content

Conversation

JosueOb
Copy link
Collaborator

@JosueOb JosueOb commented Sep 6, 2021

Description

The dark mode is a temporary change in the color palette of the software, this feature offers several benefits, among the main ones are: it prevents the user's vision from getting tired in less time and battery-saving due to the reduction of the screen brightness.

Solution

Using Tailwind CSS to style Time Tracker UI in dark mode, allowing the user to switch between light and dark mode. Also, Tailwind was configured to set the color palette for the project.

Implementation example

Light mode

light-mode

Dark mode

dark-mode

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #746 (f6fd309) into master (2b16e33) will increase coverage by 0.09%.
The diff coverage is 96.15%.

❗ Current head f6fd309 differs from pull request most recent head 95d1ed3. Consider uploading reports for the commit 95d1ed3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   95.54%   95.64%   +0.09%     
==========================================
  Files         106      107       +1     
  Lines        2247     2273      +26     
  Branches      169      175       +6     
==========================================
+ Hits         2147     2174      +27     
+ Misses         57       54       -3     
- Partials       43       45       +2     
Impacted Files Coverage Δ
...les/shared/components/sidebar/sidebar.component.ts 90.47% <ø> (ø)
...e-toggle-general/feature-toggle-general.service.ts 100.00% <ø> (ø)
.../feature-toggles/feature-toggle-manager.service.ts 100.00% <ø> (ø)
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...time-entries-table/time-entries-table.component.ts 77.77% <100.00%> (ø)
src/environments/enum.ts 100.00% <100.00%> (ø)
...app/modules/login/services/azure.ad.b2c.service.ts 83.33% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0675eef...95d1ed3. Read the comment docs.

@bytesantiago
Copy link
Contributor

bytesantiago commented Sep 6, 2021

Hello Jose, I am not sure if you have noticed, but the content from certain entries is not visible in most tabs when using Dark mode, with exception of the Time Clock tab. Also, I see that the test coverage has not reached the expected minimum with the current changes.
On the other hand, I think that the color palette is very well implemented and looks nice.

Copy link
Contributor

@bytesantiago bytesantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @JosueOb !

@@ -62,3 +63,9 @@ body {
height: -o-calc(100vh - 12vh);
height: calc(100vh - 12vh);
}

.dark-mode-toggle{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space after .dark-mode-toggle

.dark-mode-toggle {

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JosueOb JosueOb merged commit 2709050 into master Sep 13, 2021
@JosueOb JosueOb deleted the TT-332-Dark-mode-component branch September 13, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants