Skip to content

feat: TT-321 Improve create/edit Entry modal #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2021
Merged

feat: TT-321 Improve create/edit Entry modal #735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fe8fec
feat: TT-321 Improve modal interface
jcalarcon98 Aug 23, 2021
fe57269
code-smell: TT-321 Fix code smells provided by sonarcloud
jcalarcon98 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: TT-321 Improve modal interface
  • Loading branch information
@jcalarcon98
jcalarcon98 committed Aug 24, 2021
commit 3fe8fecc19f0e6a19ef07a931ad11af83a055454
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/details-fields/details-fields.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,6 @@
</div>
<div class="modal-footer">
<button type="submit" class="btn btn-primary">Save</button>
<button #closeModal type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
<button #closeModal type="button" class="btn btn-secondary" data-dismiss="modal">Cancel</button>
</div>
</form>
13 changes: 9 additions & 4 deletions src/app/modules/time-entries/pages/time-entries.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,16 @@
<div class="modal fade" id="editRecordsByDate" tabindex="-1" role="dialog">
<div class="modal-dialog modal-dialog-centered modal-lg" role="document">
<div class="modal-content" cdkDrag (cdkDragEnded)="resetDraggablePosition($event)">
<div class="modal-header" cdkDragHandle>
<div class="modal-header">
<h5 class="modal-title">{{ entryId ? 'Edit Entry' : 'New Entry' }}</h5>
<button type="button" class="btn" (click)="detailsFields.cleanFieldsForm()">
<i class="fa fa-undo" aria-hidden="true"></i>
</button>
<div>
<button class="btn shadow-none" data-bs-toggle="tooltip" title="Clean form values" (click)="detailsFields.cleanFieldsForm()">
<i class="fa fa-eraser"></i>
</button>
<button class="btn shadow-none" data-bs-toggle="tooltip" title="Drag modal" cdkDragHandle>
<i class="fa fa-grip-vertical"></i>
</button>
</div>
</div>
<div class="modal-body">
<app-details-fields
Expand Down