-
Notifications
You must be signed in to change notification settings - Fork 1
feat: TT-321 Improve create/edit Entry modal #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 95.24% 95.41% +0.17%
==========================================
Files 106 107 +1
Lines 2206 2268 +62
Branches 169 171 +2
==========================================
+ Hits 2101 2164 +63
Misses 61 61
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working well on its functionality, and in my opinion there are not issues with the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the different opinions about the drag icon, the rest of the changes works fine, excellent job @jcalarcon98.
9177f30
to
fe57269
Compare
Kudos, SonarCloud Quality Gate passed!
|
Description
The user experience in the create/edit input modal was improved, more intuitive icons and a button to drag the modal has been added, the result is as follows:
