Skip to content

Conversation

jcalarcon98
Copy link
Contributor

Description

The user experience in the create/edit input modal was improved, more intuitive icons and a button to drag the modal has been added, the result is as follows:
image

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #735 (fe57269) into master (9a68415) will increase coverage by 0.17%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   95.24%   95.41%   +0.17%     
==========================================
  Files         106      107       +1     
  Lines        2206     2268      +62     
  Branches      169      171       +2     
==========================================
+ Hits         2101     2164      +63     
  Misses         61       61              
+ Partials       44       43       -1     
Impacted Files Coverage Δ
.../components/entry-fields/entry-fields.component.ts 97.18% <ø> (-0.04%) ⬇️
.../components/technologies/technologies.component.ts 85.18% <83.33%> (+0.81%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.40% <100.00%> (+0.16%) ⬆️
...c/app/modules/shared/utils/project-storage.util.ts 100.00% <100.00%> (ø)
...project-list-hover/project-list-hover.component.ts 90.74% <100.00%> (+0.35%) ⬆️
...-entries/components/calendar/calendar.component.ts 95.23% <100.00%> (+0.07%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.11% <100.00%> (+0.11%) ⬆️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd92ce4...fe57269. Read the comment docs.

@jcalarcon98 jcalarcon98 requested a review from ridouku August 23, 2021 23:47
Copy link
Contributor

@bytesantiago bytesantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working well on its functionality, and in my opinion there are not issues with the implementation.

Copy link
Contributor

@edgardavid2015 edgardavid2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the different opinions about the drag icon, the rest of the changes works fine, excellent job @jcalarcon98.

@jcalarcon98 jcalarcon98 force-pushed the TT-321-improve-modal-create-edit-entry branch from 9177f30 to fe57269 Compare August 24, 2021 18:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jcalarcon98 jcalarcon98 merged commit 1e9de83 into master Aug 24, 2021
@jcalarcon98 jcalarcon98 deleted the TT-321-improve-modal-create-edit-entry branch August 24, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants