Skip to content

feat: TT-18 autocomplete component for entering technologies #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

feat: TT-18 autocomplete component for entering technologies #733

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6babc3e
feat: TT-18 Allow users navigate with keyboard arrows between the tec…
jcalarcon98 Aug 23, 2021
89fcd64
refactor: TT-18 Improve code to make it more readable
jcalarcon98 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: TT-18 Improve code to make it more readable
  • Loading branch information
@jcalarcon98
jcalarcon98 committed Aug 23, 2021
commit 89fcd648f8d44bfe8369d8470e8fbf0b14584b8b
10 changes: 4 additions & 6 deletions src/app/modules/shared/components/technologies/technologies.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export class TechnologiesComponent implements OnInit, OnDestroy {
readonly ALLOW_SEARCH = true;
readonly MIN_SEARCH_TERM_LENGTH = 2;
readonly TYPE_TO_SEARCH_TEXT = 'Please enter 2 or more characters';
readonly WAITING_TIME_AFTER_KEY_UP = 400;

isLoading = false;
technologies: string[];
Expand All @@ -43,16 +44,13 @@ export class TechnologiesComponent implements OnInit, OnDestroy {
this.technologiesInputSubscription = this.technologiesInput$.pipe(
filter(searchQuery => searchQuery && searchQuery.length >= this.MIN_SEARCH_TERM_LENGTH),
distinctUntilChanged(),
debounceTime(400)
debounceTime(this.WAITING_TIME_AFTER_KEY_UP)
).subscribe((searchQuery) => this.searchTechnologies(searchQuery));

this.technologiesSubscription = technologies$.subscribe(({ isLoading, technologyList }) => {
const technologyItems = technologyList?.items;
this.isLoading = isLoading;
if ( technologyList.items ) {
this.technologies = technologyList.items;
} else {
this.technologies = [];
}
this.technologies = technologyItems ? technologyItems : [];
});
}

Expand Down