Skip to content

Conversation

jcalarcon98
Copy link
Contributor

Description

Currently the component to choose Technologies does not have such a nice user experience, it does not allow to use the keyboard arrows to select technologies.
image

Solution

It was decided to replace the entire component and use ng-select library, resulting in a much more attractive component with a better user experience. as shown in the following image:
image

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #733 (4d4367d) into master (9a68415) will increase coverage by 0.17%.
The diff coverage is 96.15%.

❗ Current head 4d4367d differs from pull request most recent head 89fcd64. Consider uploading reports for the commit 89fcd64 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   95.24%   95.41%   +0.17%     
==========================================
  Files         106      107       +1     
  Lines        2206     2267      +61     
  Branches      169      171       +2     
==========================================
+ Hits         2101     2163      +62     
  Misses         61       61              
+ Partials       44       43       -1     
Impacted Files Coverage Δ
.../components/entry-fields/entry-fields.component.ts 97.18% <ø> (-0.04%) ⬇️
.../components/technologies/technologies.component.ts 85.18% <83.33%> (+0.81%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.40% <100.00%> (+0.16%) ⬆️
...c/app/modules/shared/utils/project-storage.util.ts 100.00% <100.00%> (ø)
...project-list-hover/project-list-hover.component.ts 90.74% <100.00%> (+0.35%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.11% <100.00%> (+0.11%) ⬆️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.reducers.ts 96.55% <100.00%> (+1.81%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9871b4c...89fcd64. Read the comment docs.

@jcalarcon98 jcalarcon98 changed the title Tt 18 autocomplete component for entering technologies feat: TT-18 autocomplete component for entering technologies Aug 23, 2021
Copy link
Contributor

@edgardavid2015 edgardavid2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @jcalarcon98, this feature works fine and improves the user experience.

@jcalarcon98 jcalarcon98 force-pushed the TT-18-autocomplete-component-for-entering-technologies branch from ddbbb77 to 89fcd64 Compare August 23, 2021 16:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jcalarcon98 jcalarcon98 merged commit 4208cf8 into master Aug 23, 2021
@jcalarcon98 jcalarcon98 deleted the TT-18-autocomplete-component-for-entering-technologies branch August 23, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants