Skip to content

50 improve required field look and feel #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2020
Merged

50 improve required field look and feel #73

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6dcfa
#50 improve required field look and feel
daros10 Apr 2, 2020
5af84ac
#50 remove validation and fixed messages
daros10 Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
#50 remove validation and fixed messages
  • Loading branch information
@daros10
daros10 committed Apr 2, 2020
commit 5af84aca3551ed5f18044c28721aee55df1759af
16 changes: 1 addition & 15 deletions ...p/modules/activities-management/components/create-activity/create-activity.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,7 @@ <h1 class="card-title">Activity</h1>

<div class="form-group">
<label for="details">Description:</label>
<textarea
class="form-control"
rows="3"
id="description"
type="text"
formControlName="description"
[class.is-invalid]="description.invalid && description.touched"
required
></textarea>
<p
class="text-danger"
*ngIf="(description.dirty || description.touched) && description.invalid && description.errors.required"
>
Details activity is required.
</p>
<textarea class="form-control" rows="3" id="description" type="text" formControlName="description"></textarea>
</div>

<div class="btn-toolbar" role="toolbar">
Expand Down
2 changes: 1 addition & 1 deletion ...app/modules/activities-management/components/create-activity/create-activity.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class CreateActivityComponent {
constructor(private formBuilder: FormBuilder) {
this.activityForm = this.formBuilder.group({
name: ['', Validators.required],
description: ['', Validators.required],
description: [''],
});
}

Expand Down
6 changes: 3 additions & 3 deletions src/app/modules/project-management/components/create-project/create-project.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ <h1 class="card-title">Project</h1>
required
/>
<p class="text-danger" *ngIf="(name.dirty || name.touched) && name.invalid && name.errors.required">
Name Project is required.
Project name is required.
</p>
</div>

Expand All @@ -29,7 +29,7 @@ <h1 class="card-title">Project</h1>
required
></textarea>
<p class="text-danger" *ngIf="(details.dirty || details.touched) && details.invalid && details.errors.required">
Details Project is required.
Project details are required.
</p>
</div>

Expand All @@ -44,7 +44,7 @@ <h1 class="card-title">Project</h1>
>
</select>
<p class="text-danger" *ngIf="(status.dirty || status.touched) && status.invalid && status.errors.required">
Status Project is required.
Project status is required.
</p>
</div>

Expand Down