50 improve required field look and feel #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrisguncay
reviewed
Apr 2, 2020
| @@ -17,7 +16,7 @@ export class CreateActivityComponent { | |||
| constructor(private formBuilder: FormBuilder) { | |||
| this.activityForm = this.formBuilder.group({ | |||
| name: ['', Validators.required], | |||
| description: [''] | |||
| description: ['', Validators.required], | |||
There was a problem hiding this comment.
I don't if the description is required in activity. @enriquezrene can help us.
There was a problem hiding this comment.
It is not, let's remove this validation @daros10
macrisguncay
approved these changes
Apr 2, 2020
enriquezrene
suggested changes
Apr 2, 2020
| @@ -17,7 +16,7 @@ export class CreateActivityComponent { | |||
| constructor(private formBuilder: FormBuilder) { | |||
| this.activityForm = this.formBuilder.group({ | |||
| name: ['', Validators.required], | |||
| description: [''] | |||
| description: ['', Validators.required], | |||
There was a problem hiding this comment.
It is not, let's remove this validation @daros10
| required | ||
| /> | ||
| <p class="text-danger" *ngIf="(name.dirty || name.touched) && name.invalid && name.errors.required"> | ||
| Name Project is required. |
There was a problem hiding this comment.
Project name is required.
| required | ||
| ></textarea> | ||
| <p class="text-danger" *ngIf="(details.dirty || details.touched) && details.invalid && details.errors.required"> | ||
| Details Project is required. |
There was a problem hiding this comment.
Project details are required.
| </select> | ||
| <p class="alert alert-danger" *ngIf="(status.dirty || status.touched) && status.invalid && status.errors.required">Status Project is required.</p> | ||
| <p class="text-danger" *ngIf="(status.dirty || status.touched) && status.invalid && status.errors.required"> | ||
| Status Project is required. |
There was a problem hiding this comment.
Project status is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the previous one.