Skip to content

fix: TT-24 Display project type in projects table #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021
Merged

fix: TT-24 Display project type in projects table #685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc003eb
fix: TT-24 Display project type in projects table
lenshinoda May 14, 2021
fcf718f
fix: TT-24 Solving code smell problem and some fail test
lenshinoda May 14, 2021
3e2fb25
fix: TT-24 rename some variables
lenshinoda May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-24 Solving code smell problem and some fail test
  • Loading branch information
@lenshinoda
lenshinoda committed May 14, 2021
commit fcf718fb3f6c4ab7d9b82e6495b5e857d506b326
1 change: 0 additions & 1 deletion ...mer-management/components/projects/components/project-list/project-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ describe('ProjectListComponent', () => {
name: 'BK',
description: 'test',
};
const id = '1234';
component.projectsTypes = [nameType];
fixture.detectChanges();
fixture.whenStable().then(() => {
Expand Down
4 changes: 3 additions & 1 deletion ...customer-management/components/projects/components/project-list/project-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ export class ProjectListComponent implements OnInit, OnDestroy {

ngOnDestroy() {
this.projectsSubscription.unsubscribe();
this.projectTypesSubscription.unsubscribe();
if (this.projectTypesSubscription){
this.projectTypesSubscription.unsubscribe();
}
}

getProjectType(typeId: string) {
Expand Down