Skip to content

fix: TT-24 Display project type in projects table #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021
Merged

fix: TT-24 Display project type in projects table #685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc003eb
fix: TT-24 Display project type in projects table
lenshinoda May 14, 2021
fcf718f
fix: TT-24 Solving code smell problem and some fail test
lenshinoda May 14, 2021
3e2fb25
fix: TT-24 rename some variables
lenshinoda May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: TT-24 rename some variables
  • Loading branch information
@lenshinoda
lenshinoda committed May 18, 2021
commit 3e2fb25997d71e67e9f9fdf966b688106ca23924
2 changes: 1 addition & 1 deletion ...stomer-management/components/projects/components/project-list/project-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<tr class="d-flex" *ngFor="let project of projects">
<td class="col-sm-4">{{ project.id }}</td>
<td class="col-sm-3">{{ project.name }}</td>
<td class="col-sm-3">{{ getProjectType(project.project_type_id) }}</td>
<td class="col-sm-3">{{ getProjectTypeName(project.project_type_id) }}</td>
<td class="col-sm-1 text-center">
<button type="button" class="btn btn-sm btn-primary" (click)="updateProject(project)">
<i class="fa fa-pencil fa-xs"></i>
Expand Down
15 changes: 9 additions & 6 deletions ...mer-management/components/projects/components/project-list/project-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,25 +156,28 @@ describe('ProjectListComponent', () => {
});

it('getProjectType should be called to display it in projects table', () => {
const nameType = {
const projectType = {
id: '1234',
name: 'BK',
description: 'test',
};
const id = '1234';
component.projectsTypes = [nameType];

component.projectsTypes = [projectType];
component.ngOnInit();
const nameTest = component.getProjectType(id);
expect(nameTest).toBe('BK');

const projectNameTest = component.getProjectTypeName(id);
expect(projectNameTest).toBe('BK');
Copy link
Collaborator Author

@lenshinoda lenshinoda May 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing ('BK') here because the input of function getProjectTypeName is the project_type_id and it returns the name of the project type to render it on the table.

});

it('projects table should display Project Type', (done) => {
const nameType = {
const projectType = {
id: '1234',
name: 'BK',
description: 'test',
};
component.projectsTypes = [nameType];

component.projectsTypes = [projectType];
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
Expand Down
6 changes: 3 additions & 3 deletions ...customer-management/components/projects/components/project-list/project-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ export class ProjectListComponent implements OnInit, OnDestroy {
}
}

getProjectType(typeId: string) {
const typeName = this.projectsTypes.find(
getProjectTypeName(typeId: string) {
const typeProject = this.projectsTypes.find(
(prop) => prop.id === typeId
);
return typeName !== undefined ? typeName.name : '';
return typeProject !== undefined ? typeProject.name : '';
}

updateProject(project) {
Expand Down