Skip to content

feat: TT-217 Add FT in EntryFieldsComponent component and Add flag at validate current entry and last entry #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2021
Merged

feat: TT-217 Add FT in EntryFieldsComponent component and Add flag at validate current entry and last entry #663

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03d055d
feat: TT-217 Add FT in EntryFieldsComponent component to get the new …
VanessaIniguezG Apr 13, 2021
f128eef
fix: TT-2017 Remove blank lines
VanessaIniguezG Apr 14, 2021
b14ee76
fix: TT-217 Update test description, change the updateEntry method to…
VanessaIniguezG Apr 15, 2021
d1beacb
refactor: TT-217 Remove comments
VanessaIniguezG Apr 15, 2021
86032d5
refactor: TT-217 Remove getOwnerId method
VanessaIniguezG Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-2017 Remove blank lines
  • Loading branch information
@VanessaIniguezG
VanessaIniguezG committed Apr 14, 2021
commit f128eef35dcce87a8594e5c8a4022a4a3b25d8f7
6 changes: 0 additions & 6 deletions src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,8 @@ describe('EntryFieldsComponent', () => {
update_last_entry_if_overlap: true
};
component.newData = mockEntry;

component.isFeatureToggleActivated();

const expected = { update_last_entry_if_overlap: true };

expect(component.newData.update_last_entry_if_overlap).toEqual(expected.update_last_entry_if_overlap);
});

Expand All @@ -456,11 +453,8 @@ describe('EntryFieldsComponent', () => {
update_last_entry_if_overlap: false
};
component.newData = mockEntry;

component.isFeatureToggleActivated();

const expected = { update_last_entry_if_overlap: false };

expect(component.newData.update_last_entry_if_overlap).toEqual(expected.update_last_entry_if_overlap);
});
});
1 change: 0 additions & 1 deletion src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { formatDate } from '@angular/common';
import { getTimeEntriesDataSource } from '../../store/entry.selectors';
import { DATE_FORMAT } from 'src/environments/environment';
import { Subscription, Observable } from 'rxjs';

import { FeatureManagerService } from './../../../shared/feature-toggles/feature-toggle-manager.service';
import { AzureAdB2CService } from 'src/app/modules/login/services/azure.ad.b2c.service';

Expand Down