-
Notifications
You must be signed in to change notification settings - Fork 1
feat: TT-217 Add FT in EntryFieldsComponent component and Add flag at validate current entry and last entry #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TT-217 Add FT in EntryFieldsComponent component and Add flag at validate current entry and last entry #663
Conversation
…changes, add the flag to validate the current entry and last entry, add tests of the Feature Toggle - update-entries
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
+ Coverage 93.09% 94.21% +1.11%
==========================================
Files 85 102 +17
Lines 1564 1969 +405
Branches 107 136 +29
==========================================
+ Hits 1456 1855 +399
- Misses 67 74 +7
+ Partials 41 40 -1
Continue to review full report at Codecov.
|
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job. Only some comments that can make your solution cleaner. Also dont forget after validating these changes. All the code around UpdateCurrentOrLastEntry should be removed. -> https://github.com/ioet/time-tracker-ui/search?q=updateCurrentOrLastEntry
… updateEntryRunning method and improve name the flag FT
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job !
Add FT in EntryFieldsComponent component to get the new changes, add the flag to validate the current entry and last entry, add tests of the Feature Toggle - update-entries.