Skip to content

Conversation

VanessaIniguez
Copy link
Collaborator

Add FT in EntryFieldsComponent component to get the new changes, add the flag to validate the current entry and last entry, add tests of the Feature Toggle - update-entries.

…changes, add the flag to validate the current entry and last entry, add tests of the Feature Toggle - update-entries
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #663 (d88991c) into master (13de42e) will increase coverage by 1.11%.
The diff coverage is 95.74%.

❗ Current head d88991c differs from pull request most recent head 86032d5. Consider uploading reports for the commit 86032d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   93.09%   94.21%   +1.11%     
==========================================
  Files          85      102      +17     
  Lines        1564     1969     +405     
  Branches      107      136      +29     
==========================================
+ Hits         1456     1855     +399     
- Misses         67       74       +7     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
.../components/entry-fields/entry-fields.component.ts 93.33% <90.00%> (-6.67%) ⬇️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <92.30%> (-2.36%) ⬇️
...ponents/details-fields/details-fields.component.ts 94.00% <95.45%> (+6.82%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 90.62% <95.83%> (+1.73%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa91aa...86032d5. Read the comment docs.

@VanessaIniguez VanessaIniguez requested review from jeffqev and removed request for Angeluz-07 April 14, 2021 16:38
Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job. Only some comments that can make your solution cleaner. Also dont forget after validating these changes. All the code around UpdateCurrentOrLastEntry should be removed. -> https://github.com/ioet/time-tracker-ui/search?q=updateCurrentOrLastEntry

Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@scastillo-jp scastillo-jp merged commit 0ade8eb into master Apr 16, 2021
@scastillo-jp scastillo-jp deleted the TT-217-validate-current-entry-and-last-entry branch April 16, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants