Skip to content

feat: TT-191 Validate the new flow for permission management #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021
Merged

feat: TT-191 Validate the new flow for permission management #661

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e31352
feat: TT-191 add FT switch to sidebar.component
thegreatyamori Apr 13, 2021
cc93ed0
style: TT-191 styling sidebar code
thegreatyamori Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: TT-191 styling sidebar code
  • Loading branch information
@thegreatyamori
thegreatyamori committed Apr 13, 2021
commit cc93ed0eab8fbfcf801f6d402e09de5b11e8b494
16 changes: 6 additions & 10 deletions src/app/modules/shared/components/sidebar/sidebar.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,12 @@ describe('SidebarComponent', () => {
const route = 'time-clock';
router.navigate([route]);

component.itemsSidebar
.filter((item) => item.route === `/${route}`)
.map((item) => {
expect(item.active).toBeTrue();
});
component.itemsSidebar
.filter((item) => item.route !== `/${route}`)
.map((item) => {
expect(item.active).toBeFalse();
});
component.itemsSidebar.filter((item) => item.route === `/${route}`).map((item) => {
expect(item.active).toBeTrue();
});
component.itemsSidebar.filter((item) => item.route !== `/${route}`).map((item) => {
expect(item.active).toBeFalse();
});
});

it('List Technologies item is added when feature flag "ui-list-technologies" is enabled for user', () => {
Expand Down
30 changes: 16 additions & 14 deletions src/app/modules/shared/components/sidebar/sidebar.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ export class SidebarComponent implements OnInit, OnDestroy {
private featureManagerService: FeatureManagerService,
private featureSwitchGroup: FeatureSwitchGroupService
) {
this.navStart = this.router.events.pipe(filter((evt) => evt instanceof NavigationStart)) as Observable<
NavigationStart
>;
this.navStart = this.router.events.pipe(
filter((evt) => evt instanceof NavigationStart)
) as Observable<NavigationStart>;
}

ngOnInit(): void {
Expand Down Expand Up @@ -78,17 +78,19 @@ export class SidebarComponent implements OnInit, OnDestroy {
}

toggleListTechnologies(itemsSidebar: ItemSidebar[]) {
this.featureManagerService.isToggleEnabledForUser('ui-list-technologies').subscribe((enabled) => {
if (enabled === true) {
const listTechnologiesItem = {
route: '/technology-report',
icon: 'fas fa-user',
text: 'Technology Report',
active: false,
};
itemsSidebar.push(listTechnologiesItem);
}
});
this.featureManagerService
.isToggleEnabledForUser('ui-list-technologies')
.subscribe((enabled) => {
if (enabled === true) {
const listTechnologiesItem = {
route: '/technology-report',
icon: 'fas fa-user',
text: 'Technology Report',
active: false,
};
itemsSidebar.push(listTechnologiesItem);
}
});
}

highlightMenuOption(route) {
Expand Down