Skip to content

Conversation

thegreatyamori
Copy link
Collaborator

Using FT I added an implementation in sidebar component and corresponding unit tests

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #661 (da74e33) into master (13de42e) will increase coverage by 1.29%.
The diff coverage is 96.48%.

❗ Current head da74e33 differs from pull request most recent head cc93ed0. Consider uploading reports for the commit cc93ed0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   93.09%   94.39%   +1.29%     
==========================================
  Files          85      102      +17     
  Lines        1564     1961     +397     
  Branches      107      135      +28     
==========================================
+ Hits         1456     1851     +395     
- Misses         67       73       +6     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <92.30%> (-2.36%) ⬇️
...ponents/details-fields/details-fields.component.ts 94.00% <95.45%> (+6.82%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 90.62% <95.83%> (+1.73%) ⬆️
src/app/modules/users/store/user.reducers.ts 96.55% <96.55%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d526a...cc93ed0. Read the comment docs.

@thegreatyamori thegreatyamori merged commit 29bdef3 into master Apr 13, 2021
@thegreatyamori thegreatyamori deleted the TT-191-validate-the-new-flow-for-permission-management branch April 13, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants