Tt 26 warn of unsaved changes on customer page #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scastillo-jp
force-pushed
the
TT-26-Warn-of-unsaved-changes-on-customer-page
branch
2 times, most recently
from
8e82903 to
681b2b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 93.09% 94.28% +1.19%
==========================================
Files 85 95 +10
Lines 1564 1821 +257
Branches 107 124 +17
==========================================
+ Hits 1456 1717 +261
+ Misses 67 66 -1
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
scastillo-jp
force-pushed
the
TT-26-Warn-of-unsaved-changes-on-customer-page
branch
3 times, most recently
from
ae6ab74 to
38385db
Compare
scastillo-jp
requested review from
Angeluz-07,
eduardisrael,
kellycastrof and
thegreatyamori
scastillo-jp
force-pushed
the
TT-26-Warn-of-unsaved-changes-on-customer-page
branch
3 times, most recently
from
57bc55b to
7fff57d
Compare
scastillo-jp
force-pushed
the
TT-26-Warn-of-unsaved-changes-on-customer-page
branch
from
a0000be to
6d8b0b5
Compare
...omer-management/components/customer-info/components/customer-list/customer-list.component.ts
Outdated
Show resolved
Hide resolved
...ent/components/projects-type/components/create-project-type/create-project-type.component.ts
Outdated
Show resolved
Hide resolved
| this.getCustomerIdSubscription.unsubscribe(); | ||
| } | ||
|
|
||
| onSearchChanges(searchValue: string): void { |
There was a problem hiding this comment.
This function is identical to onSearchChanges of create-customer.ts
Here
| }); | ||
| } | ||
|
|
||
| onSearchChanges(searchValue: string): void { |
There was a problem hiding this comment.
This function is identical to onSearchChanges of create-customer.ts
Here
Angeluz-07
reviewed
Mar 19, 2021
| rows="3" | ||
| formControlName="description" | ||
| placeholder="Customer description" | ||
| (input)="onSearchChanges($event.target.value)" |
There was a problem hiding this comment.
I have a doubt. Why is the function called onSearchChanges? I remember the purpose is to check when the value Input field has changed. Maybe we need better name like onInputChange or something similar.
There was a problem hiding this comment.
Yes, the purpose is to check when the Input value or the textArea has changed.
I'm going to rename onSearchChanges
Angeluz-07
reviewed
Mar 19, 2021
...s/customer-management/components/customer-info/components/create-customer/create-customer.ts
Outdated
Show resolved
Hide resolved
Angeluz-07
reviewed
Mar 19, 2021
...s/customer-management/components/customer-info/components/create-customer/create-customer.ts
Outdated
Show resolved
Hide resolved
thegreatyamori
approved these changes
Mar 23, 2021
Angeluz-07
approved these changes
Mar 23, 2021
kellycastrof
approved these changes
Mar 23, 2021
wobravo
pushed a commit
that referenced
this pull request
Mar 25, 2021
* feat: TT-26 Warn of unsaved changes on customer pag * fix: TT-26 resolve commets
LEON12699
pushed a commit
that referenced
this pull request
Mar 29, 2021
* feat: TT-26 Warn of unsaved changes on customer pag * fix: TT-26 resolve commets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.