fix: TT-26 warn of unsaved changes on customer page (#648)

* feat: TT-26 Warn of unsaved changes on customer pag

* fix: TT-26 resolve commets

Author: scastillo-jp

src/app/modules/customer-management/components/customer-info/components/create-customer/create-customer.html

@@ -8,6 +8,7 @@
         formControlName="name"
         placeholder="Customer name"
         [class.is-invalid]="customerForm.invalid && customerForm.touched"
+        (input)="onInputChangeCustomer($event.target.value)"
         required
       />
       <span
@@ -23,6 +24,7 @@
         rows="3"
         formControlName="description"
         placeholder="Customer description"
+        (input)="onInputChangeCustomer($event.target.value)"
       ></textarea>
     </div>
       <button type="submit" class="btn btn-primary" [disabled]="!customerForm.valid">Save</button>

src/app/modules/customer-management/components/customer-info/components/create-customer/create-customer.spec.ts

@@ -140,4 +140,23 @@ describe('CreateCustomerComponent', () => {
     expect(component.changeValueAreTabsActives.emit).toHaveBeenCalledWith(component.areTabsActive);
   });
 
+  it('if detect changes in customer information, it should emit a true', () => {
+    component.hasChange = true;
+    spyOn(component.hasChangedEvent, 'emit');
+
+    component.onInputChangeCustomer('changes text');
+
+    expect(component.hasChange).toBe(true);
+    expect(component.hasChangedEvent.emit).toHaveBeenCalledWith(component.hasChange);
+  });
+
+  it('if not detect changes in customer information, it should emit a false', () => {
+    component.hasChange = false;
+    spyOn(component.hasChangedEvent, 'emit');
+
+    component.onInputChangeCustomer('');
+
+    expect(component.hasChange).toBe(false);
+    expect(component.hasChangedEvent.emit).toHaveBeenCalledWith(component.hasChange);
+  });
 });

src/app/modules/customer-management/components/customer-info/components/create-customer/create-customer.ts

@@ -23,6 +23,8 @@ import { LoadCustomerProjects, CleanCustomerProjects } from '../../../projects/c
 export class CreateCustomerComponent implements OnInit, OnDestroy {
   customerForm: FormGroup;
   @Input() areTabsActive: boolean;
+  @Input() hasChange: boolean;
+  @Output() hasChangedEvent = new EventEmitter<boolean>();
   @Output() changeValueAreTabsActives = new EventEmitter<boolean>();
   @Output() closeCustomerComponent = new EventEmitter<boolean>();
   customerToEdit: Customer;
@@ -68,6 +70,7 @@ export class CreateCustomerComponent implements OnInit, OnDestroy {
       this.store.dispatch(new LoadProjectTypes(customerData.id));
       this.store.dispatch(new LoadCustomerProjects(customerData.id));
       this.changeValueAreTabsActives.emit(true);
+      this.hasChangedEvent.emit(this.hasChange = false);
       this.customerForm.setValue({
         name: customerData.name,
         description: customerData.description,
@@ -94,4 +97,9 @@ export class CreateCustomerComponent implements OnInit, OnDestroy {
     this.store.dispatch(new ResetCustomerToEdit());
     this.closeCustomerComponent.emit(false);
   }
+
+  onInputChangeCustomer(searchValue: string): void {
+    return searchValue ? this.hasChangedEvent.emit(this.hasChange = true) :
+      this.hasChangedEvent.emit(this.hasChange = false);
+  }
 }

src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html

@@ -20,12 +20,15 @@
         <td class="col-3 text-break">{{ customer.name }}</td>
         <td class="col-4 text-center">
           <button
+            data-toggle="modal"
             (click)="editCustomer(customer.id)"
             type="button"
+            data-target="#editModal"
             class="btn btn-sm btn-primary"
           >
-            <i class="fa fa-pencil fa-xs"></i>
+            <i class="fa fa-pen fa-xs"></i>
           </button>
+
           <button
             data-toggle="modal"
             data-target="#deleteModal"
@@ -53,3 +56,16 @@
   (closeModalEvent)="deleteCustomer()"
 >
 </app-dialog>
+
+<app-dialog
+  *ngIf="showModal"
+  class="modal fade"
+  id="editModal"
+  tabindex="-1"
+  role="dialog"
+  aria-hidden="true"
+  [title]="'Edit Customer'"
+  [body]="message"
+  (closeModalEvent)="closeModal()"
+  >
+</app-dialog>

src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.spec.ts

@@ -58,13 +58,27 @@ describe('CustomerTableListComponent', () => {
     expect(store.dispatch).toHaveBeenCalledWith(new LoadCustomers());
   });
 
-  it('onClick edit, dispatch SetCustomerToEdit and enable customer form', () => {
+
+  it('Onclick Edit, if there are changes, the modal must be presented ', () => {
+    component.hasChange = true;
+    const expectMessage = 'Do you have changes in a client, do you want to discard them?';
+
+    component.editCustomer('1');
+
+    expect(component.message).toEqual(expectMessage);
+    expect(component.showModal).toBeTrue();
+  });
+
+  it('onClick edit, if there are not have changes dispatch SetCustomerToEdit, enable customer form and hidden modal', () => {
+    component.hasChange = false;
+
     spyOn(store, 'dispatch');
 
     component.editCustomer('1');
 
     expect(store.dispatch).toHaveBeenCalledWith(new SetCustomerToEdit('1'));
     expect(component.showCustomerForm).toBeTruthy();
+    expect(component.showModal).toBeFalse();
   });
 
   it('onClick edit, dispatch clean Forms in project and project type', () => {
@@ -76,6 +90,18 @@ describe('CustomerTableListComponent', () => {
     expect(store.dispatch).toHaveBeenCalledWith(new ResetProjectTypeToEdit());
   });
 
+  it('when you click close modal, you should close the modal, discard the current changes and load a new client for edit', () => {
+    spyOn(component.changeValueShowCustomerForm, 'emit');
+    spyOn(store, 'dispatch');
+
+    component.editCustomer('1');
+    component.closeModal();
+
+    expect(component.showModal).toBeFalse();
+    expect(component.changeValueShowCustomerForm.emit).toHaveBeenCalledWith(true);
+    expect(store.dispatch).toHaveBeenCalledWith(new SetCustomerToEdit('1'));
+  });
+
   it('onClick delete, dispatch DeleteCustomer', () => {
     spyOn(store, 'dispatch');
     component.idToDelete = '1';

src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.ts

@@ -20,6 +20,7 @@ import { ResetProjectTypeToEdit } from '../../../projects-type/store';
 })
 export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
   @Input() showCustomerForm: boolean;
+  @Input() hasChange: boolean;
   @Output() changeValueShowCustomerForm = new EventEmitter<boolean>();
   @Input()
   customers: Customer[] = [];
@@ -31,6 +32,7 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
   changeCustomerSubscription: Subscription;
   showModal = false;
   idToDelete: string;
+  idToEdit: string;
   message: string;
   isLoading$: Observable<boolean>;
 
@@ -77,10 +79,25 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
   }
 
   editCustomer(customerId: string) {
+    this.idToEdit = customerId;
+    if (this.hasChange) {
+      this.message = 'Do you have changes in a client, do you want to discard them?';
+      this.showModal = true;
+    } else {
+      this.showCustomerForm = true;
+      this.showModal = false;
+      this.changeValueShowCustomerForm.emit(this.showCustomerForm);
+      this.resetProjectFieldsToEdit();
+      this.store.dispatch(new SetCustomerToEdit(customerId));
+    }
+  }
+
+  closeModal() {
     this.showCustomerForm = true;
+    this.showModal = false;
     this.changeValueShowCustomerForm.emit(this.showCustomerForm);
-    this.store.dispatch(new SetCustomerToEdit(customerId));
     this.resetProjectFieldsToEdit();
+    this.store.dispatch(new SetCustomerToEdit(this.idToEdit));
   }
 
   private resetProjectFieldsToEdit() {
@@ -109,5 +126,4 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
     this.message = `Are you sure you want to delete ${item.name}?`;
     this.showModal = true;
   }
-
 }

src/app/modules/customer-management/components/management-customer-projects/management-customer-projects.component.html

@@ -55,6 +55,7 @@ <h4 class="navbar-brand nav-title">{{customerName}}</h4>
       <app-create-customer
         [areTabsActive]="areTabsActive"
         (changeValueAreTabsActives)="activeTabs($event)"
+        (hasChangedEvent)="getChanges($event)"
         (closeCustomerComponent)="closeCustomer($event)"
       ></app-create-customer>
     </div>
@@ -66,7 +67,7 @@ <h4 class="navbar-brand nav-title">{{customerName}}</h4>
       aria-labelledby="projects-type-tab"
     >
       <div class="container">
-        <app-create-project-type></app-create-project-type>
+        <app-create-project-type (hasChangedEvent)="getChanges($event)"></app-create-project-type>
         <app-project-type-list></app-project-type-list>
       </div>
     </div>
@@ -78,7 +79,7 @@ <h4 class="navbar-brand nav-title">{{customerName}}</h4>
       aria-labelledby="projects-tab"
     >
       <div class="container mb-1">
-        <app-create-project></app-create-project>
+        <app-create-project (hasChangedEvent)="getChanges($event)"></app-create-project>
         <app-project-list></app-project-list>
       </div>
     </div>

src/app/modules/customer-management/components/management-customer-projects/management-customer-projects.component.spec.ts

@@ -64,9 +64,18 @@ describe('ManagmentCustomerProjectsComponent', () => {
     component.showTab('projects');
     expect(component.activeTab).toEqual('projects');
   });
+
   it('should call close customer function', () => {
     spyOn(component.closeCustemerForm, 'emit');
     component.closeCustomer(false);
     expect(component.closeCustemerForm.emit).toHaveBeenCalledWith(false);
   });
+
+  it('with changes should emit a true ', () => {
+    spyOn(component.sendChanges, 'emit');
+
+    component.getChanges(true);
+
+    expect(component.sendChanges.emit).toHaveBeenCalledWith(true);
+  });
 });

src/app/modules/customer-management/components/management-customer-projects/management-customer-projects.component.ts

@@ -10,7 +10,9 @@ import { Component, Output, EventEmitter, OnInit } from '@angular/core';
 })
 export class ManagementCustomerProjectsComponent implements OnInit {
   @Output() closeCustemerForm = new EventEmitter<boolean>();
+  @Output() sendChanges = new EventEmitter<boolean>();
   areTabsActive: boolean;
+  hasChanged: boolean;
   activeTab: string;
   customerName: string;
 
@@ -42,4 +44,8 @@ export class ManagementCustomerProjectsComponent implements OnInit {
     this.activeTab = activeTab;
   }
 
+  getChanges($value: boolean) {
+    this.hasChanged = $value;
+    this.sendChanges.emit($value);
+  }
 }

src/app/modules/customer-management/components/projects-type/components/create-project-type/create-project-type.component.html

@@ -1,14 +1,26 @@
 <form style="width: 600px;" [formGroup]="projectTypeForm" (ngSubmit)="onSubmit(projectTypeForm.value)">
   <div class="form-group">
-    <input type="text" class="form-control form-control-sm" id="name" formControlName="name" aria-describedby=""
-      [class.is-invalid]="name.invalid && name.touched" required placeholder="Name" />
+    <input type="text"class="form-control form-control-sm"
+      id="name"
+      formControlName="name"
+      aria-describedby=""
+      [class.is-invalid]="name.invalid && name.touched"
+      required placeholder="Name"
+      (input)="onInputChangeProjectType($event.target.value)"
+    />
     <div class="text-danger" *ngIf="(name.dirty || name.touched) && name.invalid && name.errors.required">
       Name is required.
     </div>
   </div>
   <div class="form-group">
-    <textarea class="form-control form-control-sm mt-2" id="descriptionTextArea" rows="3" placeholder="Description"
-      formControlName="description"></textarea>
+    <textarea class="form-control
+      form-control-sm mt-2"
+      id="descriptionTextArea"
+      rows="3"
+      placeholder="Description"
+      formControlName="description"
+      (input)="onInputChangeProjectType($event.target.value)"
+    ></textarea>
   </div>
   <button type="submit" class="btn btn-primary" [disabled]="!projectTypeForm.valid">
     Save