Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@
[class.is-invalid]="start_date.invalid && start_date.touched"
required
(ngModelChange)="onStartDateChange($event)"
[max]="getCurrentDate()"
onkeydown="return false"
/>
</div>

Expand Down Expand Up @@ -118,6 +120,8 @@
aria-describedby="inputGroup-sizing-sm"
[class.is-invalid]="end_date.invalid && end_date.touched"
required
[max]="getCurrentDate()"
onkeydown="return false"
/>
</div>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,31 @@ describe('DetailsFieldsComponent', () => {
expect(endDateInput.value).not.toEqual(startDateInput.value);
expect(startDateInput.value).toEqual(expectedStartDate);
});

it('on get actual date should return the current date', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the references and the name of the test. Something like:
On get current date should return expected date

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actualDateExpected to expectedDate

const actualDateExpected = new Date().toISOString().split('T')[0];

expect(component.getCurrentDate()).toEqual(actualDateExpected);
});

it('on the input with id #start_date we could get the id and max value', () => {
fixture.detectChanges();
const expectDate = new Date().toISOString().split('T')[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectDate to expectedDate

const slectInput: HTMLInputElement = fixture.debugElement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you want to retrieve the selecInput. You only need to queryselector by the id.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the name slectInput should be startDateInput or dateInput

nativeElement.querySelector(`input[id="start_date"],input[max="${component.getCurrentDate()}"]`);

expect(slectInput.id).toEqual('start_date');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is neccesary to assert the value of id?

expect(slectInput.max).toEqual(expectDate);
});

it('on the input with id #end_date we could get the current Date ', () => {
fixture.detectChanges();
const expectDate = new Date().toISOString().split('T')[0];
const slectInput = fixture.debugElement.nativeElement.querySelector('[id=end_date]');

expect(slectInput.id).toEqual('end_date');
expect(slectInput.max).toEqual(expectDate);
});
/*
TODO As part of https://github.com/ioet/time-tracker-ui/issues/424 a new parameter was added to the details-field-component,
and now these couple of tests are failing. A solution to this error might be generate a Test Wrapper Component. More details here:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
this.selectedTechnologies = $event;
}

getCurrentDate(): string {
return new Date().toISOString().split('T')[0];
}

get project_id() {
return this.entryForm.get('project_id');
}
Expand Down