Skip to content

fix: TT-167 Date picker disable future dates #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2021
Merged

fix: TT-167 Date picker disable future dates #642

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62d540e
fix: TT-167 Date picker disable future dates
wobravo Feb 26, 2021
36a3b9b
fix: TT-167 Date picker disable future dates
wobravo Mar 1, 2021
056439e
fix: TT-167 Date picker disable future dates
wobravo Mar 4, 2021
4c6b655
fix: TT-167 Date picker disable future dates
wobravo Mar 5, 2021
4045b4c
fix: TT-167 Date picker disable future dates
wobravo Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: TT-167 Date picker disable future dates
  • Loading branch information
@wobravo
wobravo committed Mar 8, 2021
commit 4045b4c7acf5e35d690f50b8ffd004312ea3b1bd
22 changes: 11 additions & 11 deletions src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,29 +469,29 @@ describe('DetailsFieldsComponent', () => {
expect(startDateInput.value).toEqual(expectedStartDate);
});

it('on get actual date should return the current date', () => {
const actualDateExpected = new Date().toISOString().split('T')[0];
it('on get current date should return expected date', () => {
const expectedDate = new Date().toISOString().split('T')[0];

expect(component.getCurrentDate()).toEqual(actualDateExpected);
expect(component.getCurrentDate()).toEqual(expectedDate);
});

it('on the input with id #start_date we could get the id and max value', () => {
fixture.detectChanges();
const expectDate = new Date().toISOString().split('T')[0];
const slectInput: HTMLInputElement = fixture.debugElement.
const expectedDate = new Date().toISOString().split('T')[0];
const startDateInput: HTMLInputElement = fixture.debugElement.
nativeElement.querySelector(`input[id="start_date"],input[max="${component.getCurrentDate()}"]`);

expect(slectInput.id).toEqual('start_date');
expect(slectInput.max).toEqual(expectDate);
expect(startDateInput.id).toEqual('start_date');
expect(startDateInput.max).toEqual(expectedDate);
});

it('on the input with id #end_date we could get the current Date ', () => {
fixture.detectChanges();
const expectDate = new Date().toISOString().split('T')[0];
const slectInput = fixture.debugElement.nativeElement.querySelector('[id=end_date]');
const expectedDate = new Date().toISOString().split('T')[0];
const endDateInput = fixture.debugElement.nativeElement.querySelector('[id=end_date]');

expect(slectInput.id).toEqual('end_date');
expect(slectInput.max).toEqual(expectDate);
expect(endDateInput.id).toEqual('end_date');
expect(endDateInput.max).toEqual(expectedDate);
});
/*
TODO As part of https://github.com/ioet/time-tracker-ui/issues/424 a new parameter was added to the details-field-component,
Expand Down