Skip to content

TT-106 exponential growth UI #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2021
Merged

TT-106 exponential growth UI #637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b110353
fix: TT-106 Syntax correction in the ProjectListHover, EntryFields, T…
VanessaIniguezG Feb 6, 2021
480f033
refactor: TT-106 Use the exponentialGrowth flag to destroy unnecessar…
VanessaIniguezG Feb 8, 2021
1d9395a
refactor: TT-106 Change of variables and call of the feature toggle i…
VanessaIniguezG Feb 9, 2021
6146572
refactor: TT-106 Delete exponentialGrowth variable in the TimeClock, …
VanessaIniguezG Feb 9, 2021
38d25bf
refactor: TT-106 New tests for the ProjectListHover component to ver…
VanessaIniguezG Feb 9, 2021
b0c9e78
refactor: TT-106 Use the ngOnDestroy to destroy subscriptions running…
VanessaIniguezG Feb 11, 2021
6e889eb
refactor: TT-106 Delete unnecessary imports
VanessaIniguezG Feb 12, 2021
40db859
fix: TT-106 Syntax correction in the ProjectListHover, EntryFields, T…
VanessaIniguezG Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TT-106 Delete exponentialGrowth variable in the TimeClock, … 
…ProjectListHover and EntryFields components
  • Loading branch information
@VanessaIniguezG @scastillo-jp
VanessaIniguezG authored and scastillo-jp committed Feb 17, 2021
commit 6146572725ce62f9ae954f864f8a28e5faeaae7a
11 changes: 3 additions & 8 deletions src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
loadActivitiesSubscription: Subscription;
loadActiveEntrySubscription: Subscription;
actionSetDateSubscription: Subscription;
exponentialGrowth;

constructor(
private featureManagerService: FeatureManagerService,
Expand Down Expand Up @@ -177,9 +176,8 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
}


async ngOnDestroy():Promise<void> {
this.exponentialGrowth = await this.isFeatureToggleActivated();
if (this.exponentialGrowth) {
ngOnDestroy(): void {
if (this.isFeatureToggleActivated()) {
this.loadActivitiesSubscription.unsubscribe();
this.loadActiveEntrySubscription.unsubscribe();
this.actionSetDateSubscription.unsubscribe();
Expand All @@ -188,9 +186,6 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {

isFeatureToggleActivated() {
return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
map((enabled) => {
return enabled === true ? true : false;
})
).toPromise();
map((enabled) => enabled));
}
}
11 changes: 3 additions & 8 deletions src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
isLoading$: Observable<boolean>;
projectsSubscription: Subscription;
activeEntrySubscription: Subscription;
exponentialGrowth;

constructor(private featureManagerService: FeatureManagerService,
private formBuilder: FormBuilder, private store: Store<ProjectState>,
Expand Down Expand Up @@ -110,9 +109,8 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
}
}

async ngOnDestroy(): Promise<void> {
this.exponentialGrowth = await this.isFeatureToggleActivated();
if(this.exponentialGrowth){
ngOnDestroy(): void {
if(this.isFeatureToggleActivated()){
this.projectsSubscription.unsubscribe();
this.activeEntrySubscription.unsubscribe();
}
Expand All @@ -121,9 +119,6 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {

isFeatureToggleActivated() {
return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
map((enabled) => {
return enabled === true ? true : false;
})
).toPromise();
map((enabled) => enabled));
}
}
11 changes: 3 additions & 8 deletions src/app/modules/time-clock/pages/time-clock.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export class TimeClockComponent implements OnInit, OnDestroy {
activeTimeEntry: Entry;
clockOutSubscription: Subscription;
storeSubscription: Subscription;
exponentialGrowth;

constructor(
private featureManagerService: FeatureManagerService,
Expand Down Expand Up @@ -73,19 +72,15 @@ export class TimeClockComponent implements OnInit, OnDestroy {
}
}

async ngOnDestroy(): Promise<void> {
this.exponentialGrowth = await this.isFeatureToggleActivated();
this.exponentialGrowth && this.storeSubscription.unsubscribe();
ngOnDestroy(): void {
this.isFeatureToggleActivated() && this.storeSubscription.unsubscribe();
this.clockOutSubscription.unsubscribe();
this.storeSubscription.unsubscribe();
}

isFeatureToggleActivated() {
return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
map((enabled) => {
return enabled === true ? true : false;
})
).toPromise();
map((enabled) => enabled));
}
}

Expand Down