TT-106 exponential growth UI #637

VanessaIniguez · 2021-02-05T03:31:16Z

Resolve exponential growth of requests in TimeClock, ProjectListHover and EntryFields components.

src/app/modules/time-clock/services/entry.service.ts

src/app/modules/time-clock/pages/time-clock.component.ts

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

src/app/modules/time-clock/pages/time-clock.component.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

Angeluz-07

Some comments.

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

codecov · 2021-02-09T20:55:04Z

Codecov Report

Merging #637 (cacfee6) into master (13de42e) will increase coverage by 1.13%.
The diff coverage is 98.55%.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.13%     
==========================================
  Files          85       95      +10     
  Lines        1564     1784     +220     
  Branches      107      118      +11     
==========================================
+ Hits         1456     1681     +225     
+ Misses         67       65       -2     
+ Partials       41       38       -3

Impacted Files	Coverage Δ
src/app/app-routing.module.ts	`100.00% <ø> (ø)`
...omponents/customer-list/customer-list.component.ts	`92.10% <ø> (ø)`
...nents/time-range-form/time-range-form.component.ts	`100.00% <ø> (ø)`
...dules/time-entries/pages/time-entries.component.ts	`84.28% <92.85%> (+1.47%)`	⬆️
...ponents/details-fields/details-fields.component.ts	`93.40% <93.93%> (+6.22%)`	⬆️
src/app/modules/users/store/user.reducers.ts	`94.73% <94.73%> (ø)`
src/app/guards/login-guard/login.guard.ts	`100.00% <100.00%> (ø)`
...nologies-report-guard/technologies-report.guard.ts	`100.00% <100.00%> (ø)`
src/app/modules/login/login.component.ts	`100.00% <100.00%> (+16.66%)`	⬆️
...app/modules/login/services/azure.ad.b2c.service.ts	`86.95% <100.00%> (+4.60%)`	⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eae139...40db859. Read the comment docs.

PaulRC-ioet

I think we have to remove all these imports from the Feature Toggles that we are not using

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.spec.ts

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

src/app/modules/time-clock/pages/time-clock.component.spec.ts

src/app/modules/time-clock/pages/time-clock.component.ts

PaulRC-ioet

it seems everything is fine, good job 👍

scastillo-jp · 2021-02-11T21:18:41Z

src/app/modules/time-clock/pages/time-clock.component.spec.ts

@@ -1,3 +1,4 @@
+import { of } from 'rxjs';


Check if is using of?

src/app/modules/time-clock/pages/time-clock.component.ts

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

…imeClock components and test files

…y requests in EntryFields, ProjectListHover, TimeClock components

…n the TimeClock, EntryFields and ProjectListHover components

…ProjectListHover and EntryFields components

…fy the behavior of ngOnDestroy when the flag is true or false

… in the background when changing components and create test to validate the call to unsubscribe in the ngOnDestroy

…imeClock components and test files

VanessaIniguez assigned scastillo-jp, Angeluz-07, josepato87, israteneda and PaulRC-ioet Feb 5, 2021