Skip to content

Tt 97 grant or revoke roles to users #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2021
Merged

Tt 97 grant or revoke roles to users #626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9bb5fb
TT-97 feat: add grant or revoke role admin to users
PaulRC-ioet Jan 15, 2021
2a0472e
TT-97 fix: refactor code
PaulRC-ioet Jan 15, 2021
d3dc13f
fix: TT-97 add some test to feature
PaulRC-ioet Jan 18, 2021
72aa934
fix: TT-97 Add new tests and fix a typo errors
PaulRC-ioet Jan 18, 2021
ace58de
fix: TT-97 fix typo errors
PaulRC-ioet Jan 18, 2021
35d8c8b
fix: TT-97 Remove a function failed
PaulRC-ioet Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-97 fix typo errors
  • Loading branch information
@PaulRC-ioet
PaulRC-ioet committed Jan 18, 2021
commit ace58de6fda7d022fb733c261fa429fb9350b085
2 changes: 1 addition & 1 deletion src/app/modules/users/components/users-list/users-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ describe('UsersListComponent', () => {

const toggleValues = [true, false];
toggleValues.map((toggleValue) => {
it(`when FeatureToggle is ${toggleValue} should return true`, () => {
it(`when FeatureToggle is ${toggleValue} should return ${toggleValue}`, () => {
spyOn(featureManagerService, 'isToggleEnabledForUser').and.returnValue(of(toggleValue));

const isFeatureToggleActivated: Observable<boolean> = component.isFeatureToggleActivated();
Expand Down
8 changes: 3 additions & 5 deletions src/app/modules/users/components/users-list/users-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,8 @@ export class UsersListComponent implements OnInit, OnDestroy, AfterViewInit {
}

isFeatureToggleActivated() {
return this.featureManagerService.isToggleEnabledForUser('ui-list-test-users').pipe(
map((enabled) => {
return enabled === true ? true : false;
})
);
return this.featureManagerService
.isToggleEnabledForUser('ui-list-test-users')
.pipe(map((enabled) => (enabled === true ? true : false)));
}
}