Skip to content

Conversation

PaulRC-ioet
Copy link
Contributor

Feature that allows users to grant and revoke roles

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #626 (35d8c8b) into master (13de42e) will increase coverage by 0.84%.
The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   93.09%   93.93%   +0.84%     
==========================================
  Files          85       95      +10     
  Lines        1564     1782     +218     
  Branches      107      118      +11     
==========================================
+ Hits         1456     1674     +218     
  Misses         67       67              
  Partials       41       41              
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
...sers/components/users-list/users-list.component.ts 87.09% <87.09%> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106fb9f...35d8c8b. Read the comment docs.

Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a few comments. I think we would need to check how to manage the code coverage comments.

@PaulRC-ioet PaulRC-ioet merged commit d198dd0 into master Jan 18, 2021
@PaulRC-ioet PaulRC-ioet deleted the TT-97-GrantOrRevokeRolesToUsers branch January 18, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants