Skip to content

204 reports page #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2020
Merged

204 reports page #308

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b2a5093
feat: #204 Adding service method to query time entries by time range
May 28, 2020
f531825
style: #204 Improving code readability by removing dead code
May 28, 2020
5747dc3
feat: #204 Adding action, reducers, and selectors required for reports
May 28, 2020
ebdef6e
style: #204 Removing duplicated code
May 28, 2020
7747b0e
fix: #204 Fixing reducers definition
May 28, 2020
80f5d2c
feat: #204 Adding report page
May 29, 2020
77ad971
feat: #204 Extracting inline css to scss file
May 29, 2020
3bc0ae3
test: #204 Removing false positive test
May 29, 2020
a53932d
refactor: #204 Refactoring styles
May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: #204 Removing false positive test
  • Loading branch information
Juan Gabriel Guzman committed May 29, 2020
commit 3bc0ae38fb6219c2745a5da47871a2ec4bfd62cc
5 changes: 3 additions & 2 deletions src/app/modules/time-clock/services/entry.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ describe('EntryService', () => {
});

it('load all Entries', () => {
service.loadEntries(new Date().getMonth).subscribe();
const month = new Date().getMonth();
service.loadEntries(month).subscribe();

const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}`);
const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}?month=${month}`);
expect(loadEntryRequest.request.method).toBe('GET');

});
Expand Down