Skip to content

204 reports page #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 30, 2020
Merged

204 reports page #308

merged 9 commits into from
May 30, 2020

Conversation

juanultimate
Copy link
Contributor

@juanultimate juanultimate commented May 29, 2020 •
edited
Loading

  • Adding the time entries report page.
  • Fixing some errors on code.
  • Refactoring some unit tests ( Removing duplicated code)
  • Removing false positive tests
  • Improving coverage on unit tests ( Now some @effects are tested)

image

@juanultimate juanultimate requested review from enriquezrene and DiegoTinitana and removed request for enriquezrene May 29, 2020 21:04
@enriquezrene enriquezrene merged commit ad1de16 into master May 30, 2020
@enriquezrene enriquezrene deleted the 204-reports-page branch May 30, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoTinitana DiegoTinitana Awaiting requested review from DiegoTinitana

@enriquezrene enriquezrene Awaiting requested review from enriquezrene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanultimate @enriquezrene