Skip to content
Prev Previous commit
Next Next commit
fixed bugs
  • Loading branch information
daros10 committed Mar 23, 2020
commit 014aeceb92d98d3debf2b581b05e1d70aa17d480
Original file line number Diff line number Diff line change
@@ -1,10 +1,42 @@
.content-ClockIn {
padding: 2.1rem 1rem;
padding: 2.1rem 1rem;
}

.timer {
align-items: center;
display: flex;
height: 100%;
justify-content: center;
align-items: center;
display: flex;
height: 100%;
justify-content: center;
}

.place-holder-danger::-webkit-input-placeholder {
/* WebKit, Blink, Edge */
color: #909;
}

.place-holder-danger:-moz-placeholder {
/* Mozilla Firefox 4 to 18 */
color: #909;
opacity: 1;
}

.placeholder-danger::-moz-placeholder {
/* Mozilla Firefox 19+ */
color: #DC3545 !important;
opacity: 1;
}

.placeholder-danger:-ms-input-placeholder {
/* Internet Explorer 10-11 */
color: #DC3545 !important;
}

.placeholder-danger::-ms-input-placeholder {
/* Microsoft Edge */
color: #DC3545 !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why !important?
AFAIK, using this tag is discouraged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

.placeholder-danger::placeholder {
/* Most modern browsers support this now. */
color: #DC3545 !important;
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
<div class="text-center mt-3">

<div *ngIf="showAlertEnterTecnology" class="alert alert-danger" role="alert">
Field technology is requiered. Enter this field for clock out.
</div>

<div class="text-center mt-5">
<div class="card">
<div class="card-header">
<div class="row">
Expand Down Expand Up @@ -62,7 +57,8 @@ <h6 class="text-left"><strong>Projects</strong></h6>
<div class="form-group row">
<label for="inputTechnology" class="col-sm-2 col-form-label text-center"><strong>Technology</strong></label>
<div class="col-sm-10">
<input #data type="text" (keyup)="enterTechnology(data.value)" class="form-control">
<input *ngIf="!showAlertEnterTecnology" #data type="text" (keyup)="enterTechnology(data.value)" class="form-control">
<input *ngIf="showAlertEnterTecnology" #data type="text" (keyup)="enterTechnology(data.value)" class="form-control border-danger placeholder-danger " placeholder="Field technology is requiered. Enter this field for clock out.">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technology field is required. Enter this field to clock out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</div>
</div>
</form>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ export class TimeClockComponent implements OnInit {
seconds: number;
interval;
dataTechnology: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technologies entered are going to be a string []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

execOnlyOneTimeCounter = 0;
execOnlyOneTimeClockIn = 0;
isClockInEnable = false;

constructor() {
this.isClockIn = true;
Expand All @@ -42,6 +45,7 @@ export class TimeClockComponent implements OnInit {
}

employeClockIn(): boolean {
this.isClockInEnable = true;
this.isClockIn = !this.isClockIn;
this.startTimer();
this.setTimeToInOut();
Expand All @@ -53,12 +57,10 @@ export class TimeClockComponent implements OnInit {
this.isClockIn = false;
this.showAlertEnterTecnology = true;
} else {
this.dataTechnology = '';
this.isClockIn = true;
this.isEnterTechnology = false;
this.showAlertEnterTecnology = false;
this.setVarToEmpty();
this.pauseTimer();
this.setTimeToInOut();

}
}

Expand All @@ -72,15 +74,20 @@ export class TimeClockComponent implements OnInit {
}

setShowFields(show: boolean) {
this.isClockIn = false;
this.showFields = show;
this.startTimer();
this.setTimeToInOut();
if ( this.isClockInEnable !== true ) {
this.isClockIn = false;
this.showFields = show;
if ( this.execOnlyOneTimeCounter === 0 ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ===0?
What is going to happen if not?
I'd rather do something like:

if(!isTimerStarted){
   this.startTimer();
   isTimerStarted = true;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

this.startTimer();
this.execOnlyOneTimeCounter++;
}
this.setTimeToInOut();
}
}

startTimer() {
this.interval = setInterval(() => {
this.timer();
this.timer();
}, 1000 );
}

Expand All @@ -101,10 +108,24 @@ export class TimeClockComponent implements OnInit {
}

setTimeToInOut() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this function doing?
its name is weird :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function to establish arrival and departure times for employees

this.currentDate = new Date();
this.hour = this.currentDate.getHours();
this.minute = this.currentDate.getMinutes();
this.seconds = this.currentDate.getSeconds();
if ( this.execOnlyOneTimeClockIn === 0 ) {
this.currentDate = new Date();
this.hour = this.currentDate.getHours();
this.minute = this.currentDate.getMinutes();
this.seconds = this.currentDate.getSeconds();
this.execOnlyOneTimeClockIn++;
}

}

setVarToEmpty() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you find a better name like: setDefaultValuesToFields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

this.dataTechnology = '';
this.isClockIn = true;
this.isEnterTechnology = false;
this.showAlertEnterTecnology = false;
this.execOnlyOneTimeClockIn = 0;
this.execOnlyOneTimeCounter = 0;
this.isClockInEnable = false;
}

ngOnInit(): void {}
Expand Down