Time clock timer component #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Mar 23, 2020
… Time-Clock-Timer-Component
enriquezrene
suggested changes
Mar 23, 2020
| @@ -62,7 +57,8 @@ <h6 class="text-left"><strong>Projects</strong></h6> | |||
| <div class="form-group row"> | |||
| <label for="inputTechnology" class="col-sm-2 col-form-label text-center"><strong>Technology</strong></label> | |||
| <div class="col-sm-10"> | |||
| <input #data type="text" (keyup)="enterTechnology(data.value)" class="form-control"> | |||
| <input *ngIf="!showAlertEnterTecnology" #data type="text" (keyup)="enterTechnology(data.value)" class="form-control"> | |||
| <input *ngIf="showAlertEnterTecnology" #data type="text" (keyup)="enterTechnology(data.value)" class="form-control border-danger placeholder-danger " placeholder="Field technology is requiered. Enter this field for clock out."> | |||
There was a problem hiding this comment.
Technology field is required. Enter this field to clock out.
|
|
||
| .placeholder-danger::-ms-input-placeholder { | ||
| /* Microsoft Edge */ | ||
| color: #DC3545 !important; |
There was a problem hiding this comment.
why !important?
AFAIK, using this tag is discouraged.
| if ( this.isClockInEnable !== true ) { | ||
| this.isClockIn = false; | ||
| this.showFields = show; | ||
| if ( this.execOnlyOneTimeCounter === 0 ) { |
There was a problem hiding this comment.
why ===0?
What is going to happen if not?
I'd rather do something like:
if(!isTimerStarted){
this.startTimer();
isTimerStarted = true;
}
| @@ -29,6 +29,9 @@ export class TimeClockComponent implements OnInit { | |||
| seconds: number; | |||
| interval; | |||
| dataTechnology: string; | |||
There was a problem hiding this comment.
technologies entered are going to be a string []
| @@ -101,10 +108,24 @@ export class TimeClockComponent implements OnInit { | |||
| } | |||
|
|
|||
| setTimeToInOut() { | |||
There was a problem hiding this comment.
what is this function doing?
its name is weird :(
There was a problem hiding this comment.
function to establish arrival and departure times for employees
|
|
||
| } | ||
|
|
||
| setVarToEmpty() { |
There was a problem hiding this comment.
can you find a better name like: setDefaultValuesToFields?
enriquezrene
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #9.
The features implemented are:
-When you click on clockIn button, UI display a timer for indicate the time that you work, clockIn change to ClockOut and in the top you can see your entry time.
-When you click on clockOut button, the timer is paused and in the top you can see your exit time. (If the field Technology is empty the user need to enter the information to clockOut).