#29 Get Technologies #118
Merged
#29 Get Technologies #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Apr 14, 2020
scripts/populate-keys.sh
Outdated
| @@ -4,3 +4,5 @@ | |||
| echo 'export const AUTHORITY = "'$AUTHORITY'";' >> src/environments/keys.ts | |||
| echo 'export const CLIENT_ID = "'$CLIENT_ID'";' >> src/environments/keys.ts | |||
| echo 'export const SCOPES = ["'$SCOPES'"];' >> src/environments/keys.ts | |||
| echo 'export const STACK_EXCHANGE_ID = ["'$STACK_EXCHANGE_ID'"];' >> src/environments/keys.ts | |||
There was a problem hiding this comment.
I think you need to remove the brackets and only have his line as:
echo 'export const STACK_EXCHANGE_ID = "'$STACK_EXCHANGE_ID'";' >> src/environments/keys.ts
scripts/populate-keys.sh
Outdated
| @@ -4,3 +4,5 @@ | |||
| echo 'export const AUTHORITY = "'$AUTHORITY'";' >> src/environments/keys.ts | |||
| echo 'export const CLIENT_ID = "'$CLIENT_ID'";' >> src/environments/keys.ts | |||
| echo 'export const SCOPES = ["'$SCOPES'"];' >> src/environments/keys.ts | |||
| echo 'export const STACK_EXCHANGE_ID = ["'$STACK_EXCHANGE_ID'"];' >> src/environments/keys.ts | |||
| echo 'export const STACK_EXCHANGE_ACCESS_TOKEN = ["'$STACK_EXCHANGE_ACCESS_TOKEN'"];' >> src/environments/keys.ts | |||
| @Input() entryToEdit; | ||
| @Input() formType: string; | ||
| @Output() saveEntry = new EventEmitter(); | ||
| @ViewChild('closeModal') closeModal: ElementRef; | ||
| entryForm: FormGroup; | ||
| technologies: Technology; |
There was a problem hiding this comment.
technologies or technology. it looks like technology since the type is not an array or any kind of collection.
| @@ -4,7 +4,7 @@ export interface Entry { | |||
| startDate: string; | |||
| endDate: string; | |||
| activity: string; | |||
| technology: string; | |||
Comment on lines
5
to
7
| LOAD_TECHNOLOGY = '[Technology] LOAD_TECHNOLOGY', | ||
| LOAD_TECHNOLOGY_SUCCESS = '[Technology] LOAD_TECHNOLOGY_SUCCESS', | ||
| LOAD_TECHNOLOGY_FAIL = '[Technology] LOAD_TECHNOLOGY_FAIL', |
There was a problem hiding this comment.
I think here we are not LOADING but FINDING so:
FIND_TECHNOLOGIES
FIND_TECHNOLOGIES_SUCESS
FIND_TECHNOLOGIES_FAIL
jorgecod
force-pushed
the
29/get-technologies
branch
from
9f6d155 to
a69a911
Compare
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 91.85% 92.90% +1.04%
==========================================
Files 43 47 +4
Lines 393 437 +44
Branches 22 26 +4
==========================================
+ Hits 361 406 +45
+ Misses 26 24 -2
- Partials 6 7 +1
Continue to review full report at Codecov.
|
jorgecod
force-pushed
the
29/get-technologies
branch
from
a69a911 to
b9f1262
Compare
jorgecod
force-pushed
the
29/get-technologies
branch
from
b9f1262 to
afc20cc
Compare
enriquezrene
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29